From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by arlo.cworth.org (Postfix) with ESMTP id 470F96DE0ACD for ; Fri, 11 Sep 2015 13:44:11 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at cworth.org X-Spam-Flag: NO X-Spam-Score: 0.193 X-Spam-Level: X-Spam-Status: No, score=0.193 tagged_above=-999 required=5 tests=[AWL=0.733, RP_MATCHES_RCVD=-0.55, T_HEADER_FROM_DIFFERENT_DOMAINS=0.01] autolearn=disabled Received: from arlo.cworth.org ([127.0.0.1]) by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id NITcsbMt4lMV for ; Fri, 11 Sep 2015 13:44:09 -0700 (PDT) Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34]) by arlo.cworth.org (Postfix) with ESMTP id C5B656DE09FB for ; Fri, 11 Sep 2015 13:44:08 -0700 (PDT) Received: by guru.guru-group.fi (Postfix, from userid 501) id B56BE1001E5; Fri, 11 Sep 2015 23:44:12 +0300 (EEST) From: Tomi Ollila To: notmuch@notmuchmail.org Subject: [PATCH] make test: NOTMUCH_TEST_QUIET=1 is now the default Date: Fri, 11 Sep 2015 23:44:11 +0300 Message-Id: <1442004251-32325-1-git-send-email-tomi.ollila@iki.fi> X-Mailer: git-send-email 2.0.0 Cc: tomi.ollila@iki.fi X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 11 Sep 2015 20:44:11 -0000 make test V=1 (or any other value than 0) and make test V=0 works similar way as build in general --- This is 2nd try: In first one I changed test-lib.sh -- there problem was the precedence between command line argument and NOTMUCH_TEST_QUIET environment variable. Here I don't see a problem there (although env NOTMUCH_TEST_QUIET=1 make test V=1 will make environment variable overrule the V=1 -- I am not sure who cares, though :D) Anyway, Someone(TM) may have better solution in mind, so let's get bikeshedding going! test/Makefile.local | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/test/Makefile.local b/test/Makefile.local index 2331ceb..2b18691 100644 --- a/test/Makefile.local +++ b/test/Makefile.local @@ -56,7 +56,17 @@ TEST_BINARIES := $(TEST_BINARIES:.cc=) test-binaries: $(TEST_BINARIES) test: all test-binaries +ifeq ($V,) + @echo 'Use "$(MAKE) V=1" to print test headings and PASSIng results.' + @env NOTMUCH_TEST_QUIET=1 ${test_src_dir}/notmuch-test $(OPTIONS) +else +# The user has explicitly enabled quiet execution. +ifeq ($V,0) + @env NOTMUCH_TEST_QUIET=1 ${test_src_dir}/notmuch-test $(OPTIONS) +else @${test_src_dir}/notmuch-test $(OPTIONS) +endif +endif check: test -- 2.4.3