unofficial mirror of notmuch@notmuchmail.org
 help / color / mirror / code / Atom feed
From: Tomi Ollila <tomi.ollila@iki.fi>
To: notmuch@notmuchmail.org
Cc: tomi.ollila@iki.fi
Subject: [PATCH] make test: NOTMUCH_TEST_QUIET=1 is now the default
Date: Fri, 11 Sep 2015 23:44:11 +0300	[thread overview]
Message-ID: <1442004251-32325-1-git-send-email-tomi.ollila@iki.fi> (raw)

make test V=1 (or any other value than 0) and make test V=0
works similar way as build in general
---

This is 2nd try: In first one I changed test-lib.sh -- there problem
was the precedence between command line argument and NOTMUCH_TEST_QUIET
environment variable. Here I don't see a problem there (although
env NOTMUCH_TEST_QUIET=1 make test V=1 will make environment variable
overrule the V=1 -- I am not sure who cares, though :D)

Anyway, Someone(TM) may have better solution in mind, so let's
get bikeshedding going!

 test/Makefile.local | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/test/Makefile.local b/test/Makefile.local
index 2331ceb..2b18691 100644
--- a/test/Makefile.local
+++ b/test/Makefile.local
@@ -56,7 +56,17 @@ TEST_BINARIES := $(TEST_BINARIES:.cc=)
 test-binaries: $(TEST_BINARIES)
 
 test:	all test-binaries
+ifeq ($V,)
+	@echo 'Use "$(MAKE) V=1" to print test headings and PASSIng results.'
+	@env NOTMUCH_TEST_QUIET=1 ${test_src_dir}/notmuch-test $(OPTIONS)
+else
+# The user has explicitly enabled quiet execution.
+ifeq ($V,0)
+	@env NOTMUCH_TEST_QUIET=1 ${test_src_dir}/notmuch-test $(OPTIONS)
+else
 	@${test_src_dir}/notmuch-test $(OPTIONS)
+endif
+endif
 
 check: test
 
-- 
2.4.3

             reply	other threads:[~2015-09-11 20:44 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-11 20:44 Tomi Ollila [this message]
2015-09-20 11:31 ` [PATCH] make test: NOTMUCH_TEST_QUIET=1 is now the default David Bremner
2015-09-20 12:28   ` Tomi Ollila
2015-09-24 12:13     ` David Bremner
2015-09-25 11:51 ` David Bremner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://notmuchmail.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1442004251-32325-1-git-send-email-tomi.ollila@iki.fi \
    --to=tomi.ollila@iki.fi \
    --cc=notmuch@notmuchmail.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://yhetil.org/notmuch.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).