From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by arlo.cworth.org (Postfix) with ESMTP id B21106DE14D8 for ; Mon, 27 Jul 2015 12:00:31 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at cworth.org X-Spam-Flag: NO X-Spam-Score: 0.166 X-Spam-Level: X-Spam-Status: No, score=0.166 tagged_above=-999 required=5 tests=[AWL=0.156, T_HEADER_FROM_DIFFERENT_DOMAINS=0.01] autolearn=disabled Received: from arlo.cworth.org ([127.0.0.1]) by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 4G0stI5rLOvt for ; Mon, 27 Jul 2015 12:00:29 -0700 (PDT) X-Greylist: delayed 1002 seconds by postgrey-1.35 at arlo; Mon, 27 Jul 2015 12:00:29 PDT Received: from gitolite.debian.net (gitolite.debian.net [87.98.215.224]) by arlo.cworth.org (Postfix) with ESMTPS id 454496DE14D6 for ; Mon, 27 Jul 2015 12:00:29 -0700 (PDT) Received: from remotemail by gitolite.debian.net with local (Exim 4.80) (envelope-from ) id 1ZJnMe-0001OC-Gw; Mon, 27 Jul 2015 18:43:04 +0000 Received: (nullmailer pid 24392 invoked by uid 1000); Mon, 27 Jul 2015 18:42:49 -0000 From: David Bremner To: notmuch@notmuchmail.org Subject: [PATCH] build: add "set -e" to version script generation Date: Mon, 27 Jul 2015 20:42:32 +0200 Message-Id: <1438022552-24342-1-git-send-email-david@tethera.net> X-Mailer: git-send-email 2.1.4 X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 27 Jul 2015 19:00:31 -0000 It turns out that on certain systems like FreeBSD, c++filt is not installed by default. It's basically OK if we fail the build in that case, but what's really not OK is for the build to continue and generate bad binaries. --- lib/gen-version-script.sh | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/gen-version-script.sh b/lib/gen-version-script.sh index 64a7374..aa1ca43 100644 --- a/lib/gen-version-script.sh +++ b/lib/gen-version-script.sh @@ -1,3 +1,4 @@ +set -e # we go through a bit of work to get the unmangled names of the # typeinfo symbols because of -- 2.1.4