From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <bremner@tesseract.cs.unb.ca>
Received: from localhost (localhost [127.0.0.1])
 by arlo.cworth.org (Postfix) with ESMTP id 274616DE137E
 for <notmuch@notmuchmail.org>; Tue, 19 May 2015 13:54:59 -0700 (PDT)
X-Virus-Scanned: Debian amavisd-new at cworth.org
X-Spam-Flag: NO
X-Spam-Score: 0.3
X-Spam-Level: 
X-Spam-Status: No, score=0.3 tagged_above=-999 required=5 tests=[AWL=0.290,
 T_HEADER_FROM_DIFFERENT_DOMAINS=0.01] autolearn=disabled
Received: from arlo.cworth.org ([127.0.0.1])
 by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024)
 with ESMTP id Uji9Xiw_BS80 for <notmuch@notmuchmail.org>;
 Tue, 19 May 2015 13:54:57 -0700 (PDT)
Received: from mx.xen14.node3324.gplhost.com (gitolite.debian.net
 [87.98.215.224])
 by arlo.cworth.org (Postfix) with ESMTPS id 4230F6DE10F8
 for <notmuch@notmuchmail.org>; Tue, 19 May 2015 13:54:56 -0700 (PDT)
Received: from remotemail by mx.xen14.node3324.gplhost.com with local (Exim
 4.80) (envelope-from <bremner@tesseract.cs.unb.ca>)
 id 1YuoVn-0001Py-6M; Tue, 19 May 2015 20:53:15 +0000
Received: (nullmailer pid 26675 invoked by uid 1000); Tue, 19 May 2015
 20:52:14 -0000
From: David Bremner <david@tethera.net>
To: Ronny Chevalier <chevalier.ronny@gmail.com>, David Bremner
 <david@tethera.net>
Subject: [PATCH] configure: Add sanity checking for environment variables
Date: Tue, 19 May 2015 22:52:08 +0200
Message-Id: <1432068728-26587-1-git-send-email-david@tethera.net>
X-Mailer: git-send-email 2.1.4
In-Reply-To: <CABPZE7+zDwFj7Y1OMU0DVwpwUedK6qUZLQcKEZTMNdRr0A=NeQ@mail.gmail.com>
References: <CABPZE7+zDwFj7Y1OMU0DVwpwUedK6qUZLQcKEZTMNdRr0A=NeQ@mail.gmail.com>
Cc: notmuch@notmuchmail.org
X-BeenThere: notmuch@notmuchmail.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: "Use and development of the notmuch mail system."
 <notmuch.notmuchmail.org>
List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
List-Archive: <http://notmuchmail.org/pipermail/notmuch/>
List-Post: <mailto:notmuch@notmuchmail.org>
List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
X-List-Received-Date: Tue, 19 May 2015 20:54:59 -0000

Passing in environment variables incompatible with the compiler may
cause other parts of the configure script to fail in hard to
understand ways, so we abort early.
---

This doesn't actually fix the problem Ronny points out, but a more
serious one where configure can actually fail when using gcc, if
e.g. nonsense is passed in CFLAGS.

 configure | 30 ++++++++++++++++++++++++++++--
 1 file changed, 28 insertions(+), 2 deletions(-)

diff --git a/configure b/configure
index 4af7ba9..cf618e8 100755
--- a/configure
+++ b/configure
@@ -269,6 +269,34 @@ dependencies are available:
 EOF
 
 errors=0
+printf "int main(void){return 0;}\n" > minimal.c
+
+printf "Sanity checking C compilation environment... "
+if ${CC} ${CFLAGS} ${CPPFLAGS}  minimal.c ${LDFLAGS} -o minimal > /dev/null 2>&1
+then
+    printf "Ok.\n"
+else
+    printf "Fail.\n"
+    errors=$((errors + 1))
+fi
+
+printf "Sanity checking C++ compilation environment... "
+if ${CXX} ${CXXFLAGS} ${CPPFLAGS}  minimal.c ${LDFLAGS} -o minimal > /dev/null 2>&1
+then
+    printf "Ok.\n"
+else
+    printf "Fail.\n"
+    errors=$((errors + 1))
+fi
+
+if [ $errors -gt 0 ]; then
+    cat <<EOF
+*** Error: Initial sanity checking of environment failed.  Please try
+running configure in a clean environment, and if the problem persists,
+report a bug.
+EOF
+    exit 1
+fi
 
 if pkg-config --version > /dev/null 2>&1; then
     have_pkg_config=1
@@ -690,8 +718,6 @@ else
 fi
 rm -f compat/check_asctime
 
-printf "int main(void){return 0;}\n" > minimal.c
-
 printf "Checking for rpath support... "
 if ${CC} -Wl,--enable-new-dtags -Wl,-rpath,/tmp/ -o minimal minimal.c >/dev/null 2>&1
 then
-- 
2.1.4