unofficial mirror of notmuch@notmuchmail.org
 help / color / mirror / code / Atom feed
From: Gaute Hope <eg@gaute.vetsj.com>
To: David Bremner <david@tethera.net>,
	Baptiste <bateast@bat.fr.eu.org>,
	notmuch@notmuchmail.org
Subject: Re: [PATCH] Re: Add /renew/ tag to moved/renamed/reflagged messages
Date: Sat, 11 Apr 2015 09:12:11 +0000	[thread overview]
Message-ID: <1428743351-astroid-1-syzinp7fwu-1358@strange> (raw)
In-Reply-To: <87pp7bwn93.fsf@maritornes.cs.unb.ca>

Excerpts from David Bremner's message of April 11, 2015 1:56:
> Baptiste <bateast@bat.fr.eu.org> writes:
> 
>> Hi, 
>>
>>> What about another automatic tag to re-add to an existing mail when =notmuch new= detect a moved, renamed or reflagged message ...
>>
>> the following code sample seems to actually do the job …
>>
> 
> Sorry I still haven't had a chance to review your patch in detail. A few
> things I did wonder about
> 
> - There is a patch series in progress to add a "last modified time" to
>   all messages [1]. It seems like this should also work for your case
>   since renaming counts as modification in this context. It might not be
>   quite as easy/efficient for your use case as your proposal, but it
>   seems like it should work.
> 
> - What about messages added by notmuch-insert? I guess you are maybe not
>   using it, but it seems odd to only support changes detected in
>   notmuch-new.
> 
> - This might be because I haven't worked through the details, but it
>   isn't obvious to me how your patch behaves with messages with multiple
>   files on disk.
> 
> 
> 
> [1]: id:1428274754-1698-1-git-send-email-david@tethera.net

I think I sent in something similar [2] before the lastmod stuff, there
are some issues with reliably detecting all changes. Especially, changes
that do not result in a rename. It would be made obsolete by the lastmod
series though.

- gaute

[2]: id:1396800683-9164-1-git-send-email-eg@gaute.vetsj.com 


  reply	other threads:[~2015-04-11  9:12 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-04 13:07 Add /renew/ tag to moved/renamed/reflagged messages Baptiste
2015-03-04 14:31 ` [PATCH] " Baptiste
2015-04-10 23:56   ` David Bremner
2015-04-11  9:12     ` Gaute Hope [this message]
2015-10-24  0:23   ` David Bremner
2015-03-05  8:43 ` francois

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://notmuchmail.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1428743351-astroid-1-syzinp7fwu-1358@strange \
    --to=eg@gaute.vetsj.com \
    --cc=bateast@bat.fr.eu.org \
    --cc=david@tethera.net \
    --cc=notmuch@notmuchmail.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://yhetil.org/notmuch.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).