unofficial mirror of notmuch@notmuchmail.org
 help / color / mirror / code / Atom feed
From: David Bremner <david@tethera.net>
To: Mark Walters <markwalters1009@gmail.com>,
	David Bremner <david@tethera.net>,
	notmuch@notmuchmail.org
Subject: [PATCH 1/4] cli: ignore config argument of notmuch_help_command
Date: Wed,  8 Apr 2015 04:30:39 +0900	[thread overview]
Message-ID: <1428435042-16503-2-git-send-email-david@tethera.net> (raw)
In-Reply-To: <1428435042-16503-1-git-send-email-david@tethera.net>

We call it with NULL at one point anyway, so it needs to work with
NULL. Since the only place we use talloc is right before exec, there
is no harm in always using NULL.
---
 notmuch.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/notmuch.c b/notmuch.c
index a5b2877..31672c3 100644
--- a/notmuch.c
+++ b/notmuch.c
@@ -177,7 +177,7 @@ exec_man (const char *page)
 }
 
 static int
-notmuch_help_command (notmuch_config_t *config, int argc, char *argv[])
+notmuch_help_command (unused (notmuch_config_t * config), int argc, char *argv[])
 {
     command_t *command;
     help_topic_t *topic;
@@ -202,14 +202,14 @@ notmuch_help_command (notmuch_config_t *config, int argc, char *argv[])
 
     command = find_command (argv[0]);
     if (command) {
-	char *page = talloc_asprintf (config, "notmuch-%s", command->name);
+	char *page = talloc_asprintf (NULL, "notmuch-%s", command->name);
 	exec_man (page);
     }
 
     for (i = 0; i < ARRAY_SIZE (help_topics); i++) {
 	topic = &help_topics[i];
 	if (strcmp (argv[0], topic->name) == 0) {
-	    char *page = talloc_asprintf (config, "notmuch-%s", topic->name);
+	    char *page = talloc_asprintf (NULL, "notmuch-%s", topic->name);
 	    exec_man (page);
 	}
     }
-- 
2.1.4

  reply	other threads:[~2015-04-07 19:33 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-05 20:59 argument parsing refactor, add shared options David Bremner
2015-04-05 20:59 ` [PATCH 1/4] cli: ignore config argument of notmuch_help_command David Bremner
2015-04-05 20:59 ` [PATCH 2/4] cli: refactor notmuch_help_command David Bremner
2015-04-05 20:59 ` [PATCH 3/4] cli: define shared options, use for --help and --version David Bremner
2015-04-05 20:59 ` [PATCH 4/4] cli: add standard option processing to config and setup David Bremner
2015-04-05 21:34   ` David Bremner
2015-04-06 12:22     ` argument parsing refactoring, round 2 David Bremner
2015-04-06 12:22       ` [Patch v2 1/4] cli: ignore config argument of notmuch_help_command David Bremner
2015-04-06 12:22       ` [Patch v2 2/4] cli: refactor notmuch_help_command David Bremner
2015-04-06 12:22       ` [Patch v2 3/4] cli: define shared options, use for --help and --version David Bremner
2015-04-07  7:22         ` Mark Walters
2015-04-06 12:22       ` [Patch v2 4/4] cli: add standard option processing to config and setup David Bremner
2015-04-07  7:24         ` Mark Walters
2015-04-07 10:20           ` David Bremner
2015-04-07  7:19       ` argument parsing refactoring, round 2 Mark Walters
2015-04-07 19:30         ` argument parsing refactoring round3 David Bremner
2015-04-07 19:30           ` David Bremner [this message]
2015-04-07 19:30           ` [PATCH 2/4] cli: refactor notmuch_help_command David Bremner
2015-04-07 19:30           ` [PATCH 3/4] cli: define shared options, use for --help and --version David Bremner
2015-04-07 19:30           ` [PATCH 4/4] cli: add standard option processing to config, help and setup David Bremner
2015-04-08 14:14             ` [PATCH] fixup! " David Bremner
2015-04-08 14:31           ` argument parsing refactoring round3 guyzmo
2015-04-08 23:53             ` David Bremner
2015-04-11  0:01               ` David Bremner
2015-04-25 19:56                 ` Tomi Ollila
2015-06-02  4:43           ` David Bremner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://notmuchmail.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1428435042-16503-2-git-send-email-david@tethera.net \
    --to=david@tethera.net \
    --cc=markwalters1009@gmail.com \
    --cc=notmuch@notmuchmail.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://yhetil.org/notmuch.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).