unofficial mirror of notmuch@notmuchmail.org
 help / color / mirror / code / Atom feed
From: Stefano Zacchiroli <zack@upsilon.cc>
To: notmuch@notmuchmail.org
Cc: "Jan N. Klug" <jan.n.klug@rub.de>, Stefano Zacchiroli <zack@upsilon.cc>
Subject: [PATCH 2/3] notmuch-mutt: support for messages that lack Message-ID headers
Date: Sat, 24 Jan 2015 10:11:40 +0100	[thread overview]
Message-ID: <1422090701-19385-3-git-send-email-zack@upsilon.cc> (raw)
In-Reply-To: <1422090701-19385-1-git-send-email-zack@upsilon.cc>

From: "Jan N. Klug" <jan.n.klug@rub.de>

For those messages, compute a synthetic Message-ID based on the SHA1
of the whole message, in the same way that notmuch would do. See:
http://git.notmuchmail.org/git/notmuch/blob/HEAD:/lib/sha1.c

To do the above, rewrite get_message_id() to scan the current message
line by line, incrementally computing a SHA1. As a consequence, drop
the dependency on Mail::Internet.

Signed-off-by: Stefano Zacchiroli <zack@upsilon.cc>
---
 contrib/notmuch-mutt/README       |  4 ++--
 contrib/notmuch-mutt/notmuch-mutt | 23 ++++++++++++++++++-----
 2 files changed, 20 insertions(+), 7 deletions(-)

diff --git a/contrib/notmuch-mutt/README b/contrib/notmuch-mutt/README
index c661447..0013ed0 100644
--- a/contrib/notmuch-mutt/README
+++ b/contrib/notmuch-mutt/README
@@ -33,10 +33,10 @@ Requirements
 
 To *run* notmuch-mutt you will need Perl with the following libraries:
 
+- Digest::SHA <https://metacpan.org/release/Digest-SHA>
+  (Debian package: libdigest-sha-perl)
 - Mail::Box <https://metacpan.org/pod/Mail::Box>
   (Debian package: libmail-box-perl)
-- Mail::Internet <https://metacpan.org/pod/Mail::Internet>
-  (Debian package: libmailtools-perl)
 - String::ShellQuote <https://metacpan.org/pod/String::ShellQuote>
   (Debian package: libstring-shellquote-perl)
 - Term::ReadLine::Gnu <https://metacpan.org/pod/Term::ReadLine::Gnu>
diff --git a/contrib/notmuch-mutt/notmuch-mutt b/contrib/notmuch-mutt/notmuch-mutt
index 4969e4b..4d30b0b 100755
--- a/contrib/notmuch-mutt/notmuch-mutt
+++ b/contrib/notmuch-mutt/notmuch-mutt
@@ -13,11 +13,11 @@ use warnings;
 
 use File::Path;
 use Getopt::Long qw(:config no_getopt_compat);
-use Mail::Internet;
 use Mail::Box::Maildir;
 use Pod::Usage;
 use String::ShellQuote;
 use Term::ReadLine;
+use Digest::SHA;
 
 
 my $xdg_cache_dir = "$ENV{HOME}/.cache";
@@ -75,10 +75,23 @@ sub prompt($$) {
 }
 
 sub get_message_id() {
-    my $mail = Mail::Internet->new(\*STDIN);
-    my $mid = $mail->head->get("message-id") or return undef;
-    $mid =~ /^<(.*)>$/;	# get message-id value
-    return $1;
+    my $mid = undef;
+    my $sha = Digest::SHA->new(1);  # SHA1 hashing
+
+    while(<STDIN>) {  # scan message line by line, looking for mid
+        if ($_ =~ /^Message-ID:\s*<(.*)>$/i) {
+	    $mid = $1;
+	    last;  # message-id found, abort scan
+        }
+	$sha->add($_);  # update hash
+    }
+
+    # Generate message-id from hash if none was found, in the same way
+    # that notmuch would do.
+    # See: http://git.notmuchmail.org/git/notmuch/blob/HEAD:/lib/sha1.c
+    $mid ||= "notmuch-sha1-".$sha->hexdigest;
+
+    return $mid;
 }
 
 sub search_action($$$@) {
-- 
2.1.4

  parent reply	other threads:[~2015-01-24  9:18 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-24  9:11 [PATCH] notmuch-mutt: support for messages that lack Message-ID Stefano Zacchiroli
2015-01-24  9:11 ` [PATCH 1/3] notmuch-mutt README: use metacpn.org/* as deps homepages Stefano Zacchiroli
2015-01-24  9:11 ` Stefano Zacchiroli [this message]
2015-01-24 14:59   ` [PATCH 2/3] notmuch-mutt: support for messages that lack Message-ID headers Jani Nikula
2015-01-24 15:21     ` Stefano Zacchiroli
2015-01-24 16:56       ` Jan N. Klug
2015-01-24 20:04         ` Jani Nikula
2015-01-24  9:11 ` [PATCH 3/3] debian packaging: drop dep notmuch-mutt -> libmailtools-perl Stefano Zacchiroli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://notmuchmail.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1422090701-19385-3-git-send-email-zack@upsilon.cc \
    --to=zack@upsilon.cc \
    --cc=jan.n.klug@rub.de \
    --cc=notmuch@notmuchmail.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://yhetil.org/notmuch.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).