From: Ian Main <imain@stemwinder.org>
To: notmuch@notmuchmail.org
Subject: [PATCH v2] VIM: Better reply handling with multiple emails
Date: Mon, 27 Oct 2014 13:33:32 -0700 [thread overview]
Message-ID: <1414442012-13995-1-git-send-email-imain@stemwinder.org> (raw)
In-Reply-To: <1412293857-31489-1-git-send-email-imain@stemwinder.org>
This patch fixes reply handling when using multiple emails. This adds a
config check for other_email and uses that information when formulating
reply headers. It will strip out your own email addresses from the
reply and set the From: to be an email of yours found in the original
message.
Note that this is built on top of the config change patch.
Ian
---
This update uses hashes to ensure no duplicate emails are inserted into
the to/cc lists. It's also just a little easier to read.
vim/notmuch.vim | 53 ++++++++++++++++++++++++++++++++++++++++++++++++-----
1 file changed, 48 insertions(+), 5 deletions(-)
diff --git a/vim/notmuch.vim b/vim/notmuch.vim
index cad9517..b480277 100644
--- a/vim/notmuch.vim
+++ b/vim/notmuch.vim
@@ -476,6 +476,7 @@ ruby << EOF
end
$db_name = nil
+ $all_emails = []
$email = $email_name = $email_address = nil
$searches = []
$threads = []
@@ -494,8 +495,14 @@ ruby << EOF
$db_name = get_config_item('database.path')
$email_name = get_config_item('user.name')
$email_address = get_config_item('user.primary_email')
+ $secondary_email_addresses = get_config_item('user.primary_email')
$email_name = get_config_item('user.name')
$email = "%s <%s>" % [$email_name, $email_address]
+ other_emails = get_config_item('user.other_email')
+ $all_emails = other_emails.split("\n")
+ # Add the primary to this too as we use it for checking
+ # addresses when doing a reply
+ $all_emails.unshift($email_address)
end
def vim_puts(s)
@@ -571,14 +578,50 @@ ruby << EOF
end
end
+ def is_our_address(address)
+ $all_emails.each do |addy|
+ if address.to_s.index(addy) != nil
+ return addy
+ end
+ end
+ return nil
+ end
+
def open_reply(orig)
reply = orig.reply do |m|
- # fix headers
- if not m[:reply_to]
- m.to = [orig[:from].to_s, orig[:to].to_s]
+ m.cc = []
+ m.to = []
+ email_addr = $email_address
+ # Use hashes for email addresses so we can eliminate duplicates.
+ to = Hash.new
+ cc = Hash.new
+ if orig[:from]
+ orig[:from].each do |o|
+ to[o.address] = o
+ end
+ end
+ if orig[:cc]
+ orig[:cc].each do |o|
+ cc[o.address] = o
+ end
+ end
+ if orig[:to]
+ orig[:to].each do |o|
+ cc[o.address] = o
+ end
+ end
+ to.each do |e_addr, addr|
+ m.to << addr
+ end
+ cc.each do |e_addr, addr|
+ if is_our_address(e_addr)
+ email_addr = is_our_address(e_addr)
+ else
+ m.cc << addr
+ end
end
- m.cc = orig[:cc]
- m.from = $email
+ m.to = m[:reply_to] if m[:reply_to]
+ m.from = "#{$email_name} <#{email_addr}>"
m.charset = 'utf-8'
end
--
1.9.3
next prev parent reply other threads:[~2014-10-27 20:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-02 23:50 [PATCH] VIM: Better reply handling with multiple emails Ian Main
2014-10-27 20:33 ` Ian Main [this message]
2014-10-27 20:35 ` [PATCH v3] " Ian Main
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1414442012-13995-1-git-send-email-imain@stemwinder.org \
--to=imain@stemwinder.org \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).