From: Austin Clements <amdragon@MIT.EDU>
To: notmuch@notmuchmail.org
Subject: [PATCH 14/14] lib: Update doc of notmuch_database_{needs_upgrade, upgrade}
Date: Sat, 26 Jul 2014 23:52:53 -0400 [thread overview]
Message-ID: <1406433173-19169-15-git-send-email-amdragon@mit.edu> (raw)
In-Reply-To: <1406433173-19169-1-git-send-email-amdragon@mit.edu>
Clients are no longer required to call these functions after opening a
database in read/write mode (which is good, because almost none of
them do!).
---
lib/notmuch.h | 21 ++++++++++++---------
1 file changed, 12 insertions(+), 9 deletions(-)
diff --git a/lib/notmuch.h b/lib/notmuch.h
index cbf2ba5..d771eb2 100644
--- a/lib/notmuch.h
+++ b/lib/notmuch.h
@@ -352,22 +352,25 @@ unsigned int
notmuch_database_get_version (notmuch_database_t *database);
/**
- * Does this database need to be upgraded before writing to it?
+ * Is the database behind the latest supported database version?
*
- * If this function returns TRUE then no functions that modify the
- * database (notmuch_database_add_message, notmuch_message_add_tag,
- * notmuch_directory_set_mtime, etc.) will work unless the function
- * notmuch_database_upgrade is called successfully first.
+ * If this function returns TRUE, then the caller may call
+ * notmuch_database_upgrade to upgrade the database. If the caller
+ * does not upgrade an out-of-date database, then some functions may
+ * fail with NOTMUCH_STATUS_UPGRADE_REQUIRED.
*/
notmuch_bool_t
notmuch_database_needs_upgrade (notmuch_database_t *database);
/**
- * Upgrade the current database.
+ * Upgrade the current database to the latest supported version.
*
- * After opening a database in read-write mode, the client should
- * check if an upgrade is needed (notmuch_database_needs_upgrade) and
- * if so, upgrade with this function before making any modifications.
+ * This ensures that all current notmuch functionality will be
+ * available on the database. After opening a database in read-write
+ * mode, it is recommended that clients check if an upgrade is needed
+ * (notmuch_database_needs_upgrade) and if so, upgrade with this
+ * function before making any modifications. If
+ * notmuch_database_needs_upgrade returns FALSE, this will be a no-op.
*
* The optional progress_notify callback can be used by the caller to
* provide progress indication to the user. If non-NULL it will be
--
2.0.0
prev parent reply other threads:[~2014-07-27 3:53 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-27 3:52 [PATCH 0/14] Implement and use database "features" Austin Clements
2014-07-27 3:52 ` [PATCH 01/14] test: Include generated dependencies for test sources Austin Clements
2014-07-27 3:52 ` [PATCH 02/14] util: Make string-util.h C++-compatible Austin Clements
2014-07-27 3:52 ` [PATCH 03/14] util: Const version of strtok_len Austin Clements
2014-07-27 3:52 ` [PATCH 04/14] new: Don't report version after upgrade Austin Clements
2014-07-27 9:33 ` Mark Walters
2014-07-27 16:24 ` Austin Clements
2014-07-27 3:52 ` [PATCH 05/14] lib: Database version 3: Introduce fine-grained "features" Austin Clements
2014-07-27 9:53 ` Mark Walters
2014-07-27 16:58 ` Austin Clements
2014-07-27 3:52 ` [PATCH 06/14] test: Tool to build DB with specific version and features Austin Clements
2014-07-27 3:52 ` [PATCH 07/14] test: Tests for future version and unknown feature handling Austin Clements
2014-07-27 8:51 ` Mark Walters
2014-07-27 16:12 ` Austin Clements
2014-07-27 3:52 ` [PATCH 08/14] lib: Simplify upgrade code using a transaction Austin Clements
2014-07-27 9:35 ` Mark Walters
2014-07-27 16:42 ` Austin Clements
2014-07-27 3:52 ` [PATCH 09/14] lib: Use database features to drive upgrade Austin Clements
2014-07-27 3:52 ` [PATCH 10/14] lib: Reorganize upgrade around document types Austin Clements
2014-07-27 3:52 ` [PATCH 11/14] lib: Report progress for combined upgrade operation Austin Clements
2014-07-27 3:52 ` [PATCH 12/14] lib: Support empty header values in database Austin Clements
2014-07-27 3:52 ` [PATCH 13/14] lib: Return an error from operations that require an upgrade Austin Clements
2014-07-27 3:52 ` Austin Clements [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1406433173-19169-15-git-send-email-amdragon@mit.edu \
--to=amdragon@mit.edu \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).