From: David Edmondson <dme@dme.org>
To: notmuch@notmuchmail.org
Subject: [PATCH v3 5/9] emacs/show: Remove the 'no-buttons option of `notmuch-show-insert-bodypart'
Date: Mon, 12 May 2014 13:29:25 +0100 [thread overview]
Message-ID: <1399897769-26809-6-git-send-email-dme@dme.org> (raw)
In-Reply-To: <1399897769-26809-1-git-send-email-dme@dme.org>
No code uses the 'no-buttons argument to
`notmuch-show-insert-bodypart', so remove it.
---
emacs/notmuch-show.el | 9 +++------
1 file changed, 3 insertions(+), 6 deletions(-)
diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el
index e511655..981b922 100644
--- a/emacs/notmuch-show.el
+++ b/emacs/notmuch-show.el
@@ -915,9 +915,7 @@ message at DEPTH in the current thread."
HIDE determines whether to show or hide the part and the button
as follows: If HIDE is nil, show the part and the button. If HIDE
-is t, hide the part initially and show the button. If HIDE is
-'no-buttons, show the part but do not add any buttons (this is
-useful for quoting in replies)."
+is t, hide the part initially and show the button."
(let* ((content-type (downcase (plist-get part :content-type)))
(mime-type (notmuch-show-mime-type part))
@@ -926,9 +924,8 @@ useful for quoting in replies)."
;; Hide the part initially if HIDE is t.
(show-part (not (equal hide t)))
;; We omit the part button for the first (or only) part if
- ;; this is text/plain, or HIDE is 'no-buttons.
- (button (when (and (not (equal hide 'no-buttons))
- (funcall notmuch-show-insert-header-p-function part))
+ ;; this is text/plain.
+ (button (when (funcall notmuch-show-insert-header-p-function part)
(notmuch-show-insert-part-header nth mime-type content-type (plist-get part :filename))))
(content-beg (point)))
--
2.0.0.rc0
next prev parent reply other threads:[~2014-05-12 12:29 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-10 9:12 reply to messages with message/rfc822 parts Mark Walters
2014-05-07 17:14 ` [RFC] [PATCH] emacs/notmuch-mua: Generate improved cited text for replies David Edmondson
2014-05-08 6:24 ` [PATCH v2] emacs: Improve the cited message included in replies David Edmondson
2014-05-08 6:24 ` [PATCH v2] emacs/notmuch-mua: Generate improved cited text for replies David Edmondson
2014-05-10 8:30 ` [PATCH v2] emacs: Improve the cited message included in replies Mark Walters
2014-05-12 6:06 ` David Edmondson
2014-05-12 8:11 ` Mark Walters
2014-05-12 8:55 ` David Edmondson
2014-05-12 12:29 ` [PATCH v3 0/9] " David Edmondson
2014-05-12 12:29 ` [PATCH v3 1/9] emacs/show: Re-arrange determination if a part header is necessary David Edmondson
2014-05-12 22:09 ` Mark Walters
2014-05-13 9:47 ` David Edmondson
2014-05-12 12:29 ` [PATCH v3 2/9] emacs/show: Allow the user to decide when part headers should be inserted David Edmondson
2014-05-12 22:15 ` Mark Walters
2014-05-13 9:49 ` David Edmondson
2014-05-12 12:29 ` [PATCH v3 3/9] emacs/show: Accommodate the lack of part header buttons David Edmondson
2014-05-12 22:16 ` Mark Walters
2014-05-12 12:29 ` [PATCH v3 4/9] emacs/mua: Generate improved cited text for replies David Edmondson
2014-05-12 22:30 ` Mark Walters
2014-05-13 10:06 ` David Edmondson
2014-05-12 12:29 ` David Edmondson [this message]
2014-05-12 22:18 ` [PATCH v3 5/9] emacs/show: Remove the 'no-buttons option of `notmuch-show-insert-bodypart' Mark Walters
2014-05-12 12:29 ` [PATCH v3 6/9] emacs/mua: Don't insert part headers in citations David Edmondson
2014-05-12 12:29 ` [PATCH v3 7/9] test: Update the test output to accord with the reply changes David Edmondson
2014-05-13 12:16 ` Mark Walters
2014-05-12 12:29 ` [PATCH v3 8/9] emacs/mua: Insert part headers depending on the message David Edmondson
2015-01-19 20:06 ` Mark Walters
2015-01-20 8:44 ` David Edmondson
2014-05-12 12:29 ` [PATCH v3 9/9] test: Update the test output to accord with more reply changes David Edmondson
2014-05-12 22:08 ` [PATCH v3 0/9] emacs: Improve the cited message included in replies Mark Walters
2014-05-13 10:01 ` David Edmondson
2014-05-13 12:05 ` Mark Walters
2016-02-06 21:27 ` David Edmondson
2017-03-12 16:26 ` reply to messages with message/rfc822 parts David Bremner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1399897769-26809-6-git-send-email-dme@dme.org \
--to=dme@dme.org \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).