* (no subject)
@ 2014-05-06 13:06 David Bremner
2014-05-06 13:06 ` [PATCH 1/2] test: allow pending break points in atomicity script David Bremner
` (3 more replies)
0 siblings, 4 replies; 7+ messages in thread
From: David Bremner @ 2014-05-06 13:06 UTC (permalink / raw)
To: notmuch
The first of these fixes a build failure on Debian Linux/armhf (and
OS/X). If the patch seems ok, I'd like to roll it into a bug fix
release. The second is more of a suggestion to make that atomicity
test easier to debug, since it seems to find the dark corners of gdb.
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH 1/2] test: allow pending break points in atomicity script.
2014-05-06 13:06 David Bremner
@ 2014-05-06 13:06 ` David Bremner
2014-05-17 21:46 ` David Bremner
2014-05-06 13:06 ` [PATCH 2/2] test: redirect gdb output to a file David Bremner
` (2 subsequent siblings)
3 siblings, 1 reply; 7+ messages in thread
From: David Bremner @ 2014-05-06 13:06 UTC (permalink / raw)
To: notmuch
This seems to fix problems with the symbol rename not being defined
at startup on at least OS/X and some Debian Linux architectures.
---
test/atomicity.gdb | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/test/atomicity.gdb b/test/atomicity.gdb
index fd67525..15adb16 100644
--- a/test/atomicity.gdb
+++ b/test/atomicity.gdb
@@ -18,6 +18,10 @@ shell echo 0 > outcount
shell touch inodes
+# work around apparent issue with lazy library loading on some
+# platforms
+set breakpoint pending on
+
break rename
commands
# As an optimization, only consider snapshots after a Xapian commit.
--
1.9.2
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH 2/2] test: redirect gdb output to a file.
2014-05-06 13:06 David Bremner
2014-05-06 13:06 ` [PATCH 1/2] test: allow pending break points in atomicity script David Bremner
@ 2014-05-06 13:06 ` David Bremner
2014-07-13 15:45 ` David Bremner
2014-05-06 18:14 ` Jameson Graef Rollins
2014-05-06 18:26 ` Re: Tomi Ollila
3 siblings, 1 reply; 7+ messages in thread
From: David Bremner @ 2014-05-06 13:06 UTC (permalink / raw)
To: notmuch
It seems that the normal output redirection in the test suite doesn't
work for gdb, but it's nice to have output in a file for debugging.
---
test/T380-atomicity.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/test/T380-atomicity.sh b/test/T380-atomicity.sh
index 1c786fa..2daef90 100755
--- a/test/T380-atomicity.sh
+++ b/test/T380-atomicity.sh
@@ -64,7 +64,7 @@ if test_require_external_prereq gdb; then
# -tty /dev/null works around a conflict between the 'timeout' wrapper
# and gdb's attempt to control the TTY.
export MAIL_DIR
- gdb -tty /dev/null -batch -x $TEST_DIRECTORY/atomicity.gdb notmuch >/dev/null 2>/dev/null
+ gdb -tty /dev/null -batch -x $TEST_DIRECTORY/atomicity.gdb notmuch 1>gdb.out 2>&1
# Get the final, golden output
notmuch search '*' > expected
--
1.9.2
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re:
2014-05-06 13:06 David Bremner
2014-05-06 13:06 ` [PATCH 1/2] test: allow pending break points in atomicity script David Bremner
2014-05-06 13:06 ` [PATCH 2/2] test: redirect gdb output to a file David Bremner
@ 2014-05-06 18:14 ` Jameson Graef Rollins
2014-05-06 18:26 ` Re: Tomi Ollila
3 siblings, 0 replies; 7+ messages in thread
From: Jameson Graef Rollins @ 2014-05-06 18:14 UTC (permalink / raw)
To: David Bremner, notmuch
[-- Attachment #1: Type: text/plain, Size: 498 bytes --]
On Tue, May 06 2014, David Bremner <david@tethera.net> wrote:
> The first of these fixes a build failure on Debian Linux/armhf (and
> OS/X). If the patch seems ok, I'd like to roll it into a bug fix
> release. The second is more of a suggestion to make that atomicity
> test easier to debug, since it seems to find the dark corners of gdb.
Hey, David. It looks like Charles's series fixes some of these same
issues and more:
id:1399395748-44920-1-git-send-email-cceleri@cs.stanford.edu
jamie.
[-- Attachment #2: Type: application/pgp-signature, Size: 818 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re:
2014-05-06 13:06 David Bremner
` (2 preceding siblings ...)
2014-05-06 18:14 ` Jameson Graef Rollins
@ 2014-05-06 18:26 ` Tomi Ollila
3 siblings, 0 replies; 7+ messages in thread
From: Tomi Ollila @ 2014-05-06 18:26 UTC (permalink / raw)
To: David Bremner, notmuch
On Tue, May 06 2014, David Bremner <david@tethera.net> wrote:
> The first of these fixes a build failure on Debian Linux/armhf (and
> OS/X). If the patch seems ok, I'd like to roll it into a bug fix
> release. The second is more of a suggestion to make that atomicity
> test easier to debug, since it seems to find the dark corners of gdb.
Series LGTM.
Tomi
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 1/2] test: allow pending break points in atomicity script.
2014-05-06 13:06 ` [PATCH 1/2] test: allow pending break points in atomicity script David Bremner
@ 2014-05-17 21:46 ` David Bremner
0 siblings, 0 replies; 7+ messages in thread
From: David Bremner @ 2014-05-17 21:46 UTC (permalink / raw)
To: notmuch
David Bremner <david@tethera.net> writes:
> This seems to fix problems with the symbol rename not being defined
> at startup on at least OS/X and some Debian Linux architectures.
pushed to release and master.
d
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 2/2] test: redirect gdb output to a file.
2014-05-06 13:06 ` [PATCH 2/2] test: redirect gdb output to a file David Bremner
@ 2014-07-13 15:45 ` David Bremner
0 siblings, 0 replies; 7+ messages in thread
From: David Bremner @ 2014-07-13 15:45 UTC (permalink / raw)
To: notmuch
David Bremner <david@tethera.net> writes:
> It seems that the normal output redirection in the test suite doesn't
> work for gdb, but it's nice to have output in a file for debugging.
pushed,
d
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2014-07-13 15:45 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-05-06 13:06 David Bremner
2014-05-06 13:06 ` [PATCH 1/2] test: allow pending break points in atomicity script David Bremner
2014-05-17 21:46 ` David Bremner
2014-05-06 13:06 ` [PATCH 2/2] test: redirect gdb output to a file David Bremner
2014-07-13 15:45 ` David Bremner
2014-05-06 18:14 ` Jameson Graef Rollins
2014-05-06 18:26 ` Re: Tomi Ollila
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).