From: Mark Walters <markwalters1009@gmail.com>
To: notmuch@notmuchmail.org
Subject: [PATCH 2/2] NEWS: document possible breakage from saved-search format change
Date: Sat, 12 Apr 2014 09:40:33 +0100 [thread overview]
Message-ID: <1397292033-26502-2-git-send-email-markwalters1009@gmail.com> (raw)
In-Reply-To: <1397292033-26502-1-git-send-email-markwalters1009@gmail.com>
If the user has unsorted or alphabetically sorted saved-searches these
should continue to work. If they have some custom lisp sort function
then it will need updating to work with the new saved-sort
format. Document this, and how the updating should be done.
Also roll in the fix for the markdown in the first part of the NEWS:
`just work' to *just work* as suggested by Tomi.
---
NEWS | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/NEWS b/NEWS
index 8aa4182..106a31f 100644
--- a/NEWS
+++ b/NEWS
@@ -24,7 +24,7 @@ Changed format for saved searches.
shows.
The variable is fully customizable and any configuration done
- through customize should `just work', with the additional options
+ through customize should *just work*, with the additional options
mentioned above. For manual customization see the documentation for
`notmuch-saved-searches`.
@@ -32,7 +32,11 @@ Changed format for saved searches.
previous versions of notmuch-emacs (even search will not work); to
fix remove the customization for notmuch-saved-searches.
-Bug fix for saved searches with newlines in them.
+ If you have a custom saved search sort function (not unsorted or
+ alphabetical) then the sort function will need to be
+ modified. Replacing (car saved-search) by (notmuch-saved-search-get
+ saved-search :name) and (cdr saved-search) by
+ (notmuch-saved-search-get saved-search :query) should be sufficient.
Split lines confuse `notmuch count --batch`, so we remove embedded
newlines before calling notmuch count.
--
1.7.10.4
next prev parent reply other threads:[~2014-04-12 8:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-12 8:40 [PATCH 1/2] emacs: hello: bugfix: make alphabetically sorted saved searches work Mark Walters
2014-04-12 8:40 ` Mark Walters [this message]
2014-04-12 8:51 ` [PATCH] emacs: hello: update docs for saved-search sort defcustom Mark Walters
2014-04-12 10:50 ` [PATCH 1/2] emacs: hello: bugfix: make alphabetically sorted saved searches work Jani Nikula
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1397292033-26502-2-git-send-email-markwalters1009@gmail.com \
--to=markwalters1009@gmail.com \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).