From: David Bremner <david@tethera.net>
To: notmuch@notmuchmail.org
Subject: [Patch v5 3/6] util: add gz_readline
Date: Tue, 1 Apr 2014 22:16:18 -0300 [thread overview]
Message-ID: <1396401381-18128-4-git-send-email-david@tethera.net> (raw)
In-Reply-To: <1396401381-18128-1-git-send-email-david@tethera.net>
The idea is to provide a more or less drop in replacement for readline
to read from zlib/gzip streams. Take the opportunity to replace
malloc with talloc.
---
util/Makefile.local | 2 +-
util/util.h | 12 +++++++++
| 76 +++++++++++++++++++++++++++++++++++++++++++++++++++++
| 11 ++++++++
4 files changed, 100 insertions(+), 1 deletion(-)
create mode 100644 util/util.h
create mode 100644 util/zlib-extra.c
create mode 100644 util/zlib-extra.h
diff --git a/util/Makefile.local b/util/Makefile.local
index 29c0ce6..e2a5b65 100644
--- a/util/Makefile.local
+++ b/util/Makefile.local
@@ -4,7 +4,7 @@ dir := util
extra_cflags += -I$(srcdir)/$(dir)
libutil_c_srcs := $(dir)/xutil.c $(dir)/error_util.c $(dir)/hex-escape.c \
- $(dir)/string-util.c $(dir)/talloc-extra.c
+ $(dir)/string-util.c $(dir)/talloc-extra.c $(dir)/zlib-extra.c
libutil_modules := $(libutil_c_srcs:.c=.o)
diff --git a/util/util.h b/util/util.h
new file mode 100644
index 0000000..8663cfc
--- /dev/null
+++ b/util/util.h
@@ -0,0 +1,12 @@
+#ifndef _UTIL_H
+#define _UTIL_H
+
+typedef enum util_status {
+ UTIL_SUCCESS = 0,
+ UTIL_ERROR = 1,
+ UTIL_OUT_OF_MEMORY,
+ UTIL_EOF,
+ UTIL_FILE,
+} util_status_t;
+
+#endif
--git a/util/zlib-extra.c b/util/zlib-extra.c
new file mode 100644
index 0000000..cb1eba0
--- /dev/null
+++ b/util/zlib-extra.c
@@ -0,0 +1,76 @@
+/* zlib-extra.c - Extra or enhanced routines for compressed I/O.
+ *
+ * Copyright (c) 2014 David Bremner
+ *
+ * This program is free software: you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation, either version 3 of the License, or
+ * (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program. If not, see http://www.gnu.org/licenses/ .
+ *
+ * Author: David Bremner <david@tethera.net>
+ */
+
+#include "zlib-extra.h"
+#include <talloc.h>
+#include <stdio.h>
+#include <string.h>
+
+/* mimic POSIX/glibc getline, but on a zlib gzFile stream, and using talloc */
+util_status_t
+gz_getline (void *talloc_ctx, char **bufptr, size_t *bufsiz, ssize_t *bytes_read,
+ gzFile stream)
+{
+ size_t len = *bufsiz;
+ char *buf = *bufptr;
+ size_t offset = 0;
+
+ if (len == 0 || buf == NULL) {
+ /* same as getdelim from gnulib */
+ len = 120;
+ buf = talloc_size (talloc_ctx, len);
+ if (buf == NULL)
+ return UTIL_OUT_OF_MEMORY;
+ }
+
+ while (1) {
+ if (! gzgets (stream, buf + offset, len - offset)) {
+ int zlib_status = 0;
+ (void) gzerror (stream, &zlib_status);
+ switch (zlib_status) {
+ case Z_OK:
+ /* follow getline behaviour */
+ *bytes_read = -1;
+ return UTIL_EOF;
+ break;
+ case Z_ERRNO:
+ return UTIL_FILE;
+ break;
+ default:
+ return UTIL_ERROR;
+ }
+ }
+
+ offset += strlen (buf + offset);
+
+ if ( buf[offset - 1] == '\n' )
+ break;
+
+ len *= 2;
+ buf = talloc_realloc (talloc_ctx, buf, char, len);
+ if (buf == NULL)
+ return UTIL_OUT_OF_MEMORY;
+ }
+
+ *bufptr = buf;
+ *bufsiz = len;
+ *bytes_read = offset;
+ return UTIL_SUCCESS;
+}
--git a/util/zlib-extra.h b/util/zlib-extra.h
new file mode 100644
index 0000000..ed46ac1
--- /dev/null
+++ b/util/zlib-extra.h
@@ -0,0 +1,11 @@
+#ifndef _ZLIB_EXTRA_H
+#define _ZLIB_EXTRA_H
+
+#include <zlib.h>
+#include "util.h"
+/* Like getline, but read from a gzFile. Allocation is with talloc */
+util_status_t
+gz_getline (void *ctx, char **lineptr, size_t *line_size, ssize_t *bytes_read,
+ gzFile stream);
+
+#endif
--
1.9.0
next prev parent reply other threads:[~2014-04-02 1:16 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-02 1:16 v5 gzip / dump restore David Bremner
2014-04-02 1:16 ` [Patch v5 1/6] dump: support gzipped output David Bremner
2014-04-02 16:50 ` Tomi Ollila
2014-04-02 1:16 ` [Patch v5 2/6] dump: when given output file name, write atomically David Bremner
2014-04-02 1:16 ` David Bremner [this message]
2014-04-02 3:26 ` [Patch v5 3/6] util: add gz_readline Austin Clements
2014-04-02 16:43 ` Tomi Ollila
2014-04-02 20:43 ` Austin Clements
2014-04-03 6:03 ` Kim Minh Kaplan
2014-04-03 6:17 ` Kim Minh Kaplan
2014-04-02 1:16 ` [Patch v5 4/6] restore: transparently support gzipped input David Bremner
2014-04-02 2:49 ` Austin Clements
2014-04-02 1:16 ` [Patch v5 5/6] notmuch-new: backup tags before database upgrade David Bremner
2014-04-02 3:35 ` Austin Clements
2014-04-02 1:16 ` [Patch v5 6/6] test: verify tag backup generated by " David Bremner
2014-04-02 2:07 ` [Patch v5 2/6] dump: when given output file name, write atomically Austin Clements
2014-04-02 20:55 ` Austin Clements
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1396401381-18128-4-git-send-email-david@tethera.net \
--to=david@tethera.net \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).