From: Jani Nikula <jani@nikula.org>
To: notmuch@notmuchmail.org
Subject: [PATCH v2] cli: abstract dump file open from the dump command
Date: Tue, 25 Mar 2014 19:48:57 +0200 [thread overview]
Message-ID: <1395769737-14598-1-git-send-email-jani@nikula.org> (raw)
In-Reply-To: <92929cc512b9e9cd5ccb7d4e537671ce84de514f.1395767165.git.jani@nikula.org>
Also expose the dump function to the rest of notmuch. No functional
changes, except for slight improvement in error handling.
---
dump-restore-private.h | 13 -------------
notmuch-client.h | 11 +++++++++++
notmuch-dump.c | 47 +++++++++++++++++++++++++++++++----------------
notmuch-restore.c | 2 +-
4 files changed, 43 insertions(+), 30 deletions(-)
delete mode 100644 dump-restore-private.h
diff --git a/dump-restore-private.h b/dump-restore-private.h
deleted file mode 100644
index 896a00430986..000000000000
--- a/dump-restore-private.h
+++ /dev/null
@@ -1,13 +0,0 @@
-#ifndef DUMP_RESTORE_PRIVATE_H
-#define DUMP_RESTORE_PRIVATE_H
-
-#include "hex-escape.h"
-#include "command-line-arguments.h"
-
-typedef enum dump_formats {
- DUMP_FORMAT_AUTO,
- DUMP_FORMAT_BATCH_TAG,
- DUMP_FORMAT_SUP
-} dump_format_t;
-
-#endif
diff --git a/notmuch-client.h b/notmuch-client.h
index 278b498a246a..d11064824ddf 100644
--- a/notmuch-client.h
+++ b/notmuch-client.h
@@ -441,5 +441,16 @@ mime_node_child (mime_node_t *parent, int child);
mime_node_t *
mime_node_seek_dfs (mime_node_t *node, int n);
+typedef enum dump_formats {
+ DUMP_FORMAT_AUTO,
+ DUMP_FORMAT_BATCH_TAG,
+ DUMP_FORMAT_SUP
+} dump_format_t;
+
+int
+notmuch_database_dump (notmuch_database_t *notmuch,
+ const char *output_file_name,
+ const char *query_str, dump_format_t output_format);
+
#include "command-line-arguments.h"
#endif
diff --git a/notmuch-dump.c b/notmuch-dump.c
index 179e2e97bf61..21702d793bcf 100644
--- a/notmuch-dump.c
+++ b/notmuch-dump.c
@@ -19,7 +19,7 @@
*/
#include "notmuch-client.h"
-#include "dump-restore-private.h"
+#include "hex-escape.h"
#include "string-util.h"
static int
@@ -115,11 +115,38 @@ database_dump_file (notmuch_database_t *notmuch, FILE *output,
return EXIT_SUCCESS;
}
+/* Dump database into output_file_name if it's non-NULL, stdout
+ * otherwise.
+ */
+int
+notmuch_database_dump (notmuch_database_t *notmuch,
+ const char *output_file_name,
+ const char *query_str, dump_format_t output_format)
+{
+ FILE *output = stdout;
+ int ret;
+
+ if (output_file_name) {
+ output = fopen (output_file_name, "w");
+ if (output == NULL) {
+ fprintf (stderr, "Error opening %s for writing: %s\n",
+ output_file_name, strerror (errno));
+ return EXIT_FAILURE;
+ }
+ }
+
+ ret = database_dump_file (notmuch, output, query_str, output_format);
+
+ if (output != stdout)
+ fclose (output);
+
+ return ret;
+}
+
int
notmuch_dump_command (notmuch_config_t *config, int argc, char *argv[])
{
notmuch_database_t *notmuch;
- FILE *output = stdout;
const char *query_str = NULL;
int ret;
@@ -145,16 +172,6 @@ notmuch_dump_command (notmuch_config_t *config, int argc, char *argv[])
if (opt_index < 0)
return EXIT_FAILURE;
- if (output_file_name) {
- output = fopen (output_file_name, "w");
- if (output == NULL) {
- fprintf (stderr, "Error opening %s for writing: %s\n",
- output_file_name, strerror (errno));
- return EXIT_FAILURE;
- }
- }
-
-
if (opt_index < argc) {
query_str = query_string_from_args (notmuch, argc - opt_index, argv + opt_index);
if (query_str == NULL) {
@@ -163,10 +180,8 @@ notmuch_dump_command (notmuch_config_t *config, int argc, char *argv[])
}
}
- ret = database_dump_file (notmuch, output, query_str, output_format);
-
- if (output != stdout)
- fclose (output);
+ ret = notmuch_database_dump (notmuch, output_file_name, query_str,
+ output_format);
notmuch_database_destroy (notmuch);
diff --git a/notmuch-restore.c b/notmuch-restore.c
index f23ab983a93d..c54d51328b51 100644
--- a/notmuch-restore.c
+++ b/notmuch-restore.c
@@ -19,7 +19,7 @@
*/
#include "notmuch-client.h"
-#include "dump-restore-private.h"
+#include "hex-escape.h"
#include "tag-util.h"
#include "string-util.h"
--
1.9.0
next prev parent reply other threads:[~2014-03-25 17:49 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-25 17:07 [PATCH 0/2] cli: notmuch dump abstractions Jani Nikula
2014-03-25 17:07 ` [PATCH 1/2] cli: abstract database dumping from the dump command Jani Nikula
2014-03-25 17:07 ` [PATCH 2/2] cli: abstract dump file open " Jani Nikula
2014-03-25 17:48 ` Jani Nikula [this message]
2014-03-26 22:01 ` [PATCH 0/2] cli: notmuch dump abstractions Mark Walters
2014-03-29 1:20 ` [PATCH] RFC: impliment gzipped output for notmuch dump David Bremner
2014-03-29 7:16 ` Tomi Ollila
2014-03-29 9:25 ` Jani Nikula
2014-03-29 12:29 ` David Bremner
2014-03-29 13:02 ` Jani Nikula
2014-03-29 16:25 ` David Bremner
2014-03-29 13:46 ` [PATCH] dump: support gzipped output David Bremner
2014-03-29 18:16 ` David Bremner
2014-03-29 18:16 ` [Patch v2 1/3] dump: support gzipped output David Bremner
2014-03-29 18:16 ` [Patch v2 2/3] util: add gzreadline David Bremner
2014-03-30 8:30 ` Tomi Ollila
2014-03-30 11:23 ` [Patch v3] " David Bremner
2014-03-30 12:45 ` Tomi Ollila
2014-03-30 14:37 ` David Bremner
2014-03-30 16:13 ` Tomi Ollila
2014-03-30 11:03 ` [Patch v2 2/3] " David Bremner
2014-03-29 18:16 ` [Patch v2 3/3] restore: transparently support gzipped input David Bremner
2014-03-30 22:33 ` [PATCH 0/2] cli: notmuch dump abstractions David Bremner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1395769737-14598-1-git-send-email-jani@nikula.org \
--to=jani@nikula.org \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).