unofficial mirror of notmuch@notmuchmail.org
 help / color / mirror / code / Atom feed
From: Tomi Ollila <tomi.ollila@iki.fi>
To: notmuch@notmuchmail.org
Cc: tomi.ollila@iki.fi
Subject: [PATCH 1/1] test: use 'bare' test names in NOTMUCH_SKIP_TESTS comparisons
Date: Tue,  4 Mar 2014 20:27:46 +0200	[thread overview]
Message-ID: <1393957666-9684-1-git-send-email-tomi.ollila@iki.fi> (raw)

The 'bare' part of test file name stays constant even when the filename
prefixes of test scripts are renumbered.
Also this change makes test skipping behave like documented.
---
 test/test-lib.sh | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/test/test-lib.sh b/test/test-lib.sh
index a1c0f27..ac6dc77 100644
--- a/test/test-lib.sh
+++ b/test/test-lib.sh
@@ -826,7 +826,7 @@ test_skip () {
 	to_skip=
 	for skp in $NOTMUCH_SKIP_TESTS
 	do
-		case $this_test.$test_count in
+		case $this_test_bare.$test_count in
 		$skp)
 			to_skip=t
 		esac
@@ -1208,7 +1208,7 @@ do
 	to_skip=
 	for skp in $NOTMUCH_SKIP_TESTS
 	do
-		case "$this_test" in
+		case "$this_test_bare" in
 		$skp)
 			to_skip=t
 		esac
-- 
1.8.0

             reply	other threads:[~2014-03-04 18:28 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-04 18:27 Tomi Ollila [this message]
2014-03-04 20:38 ` [PATCH v2] test: NOTMUCH_SKIP_TESTS accepts test names with or without Tddd- prefix Tomi Ollila
2014-03-08  2:33   ` David Bremner
2014-03-09 13:18   ` David Bremner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://notmuchmail.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1393957666-9684-1-git-send-email-tomi.ollila@iki.fi \
    --to=tomi.ollila@iki.fi \
    --cc=notmuch@notmuchmail.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://yhetil.org/notmuch.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).