From: Mark Walters <markwalters1009@gmail.com>
To: notmuch@notmuchmail.org, Austin Clements <amdragon@MIT.EDU>
Subject: [WIP Patch 0/7] emacs: show tag changes in buffer
Date: Fri, 14 Feb 2014 09:15:12 +0000 [thread overview]
Message-ID: <1392369319-24508-1-git-send-email-markwalters1009@gmail.com> (raw)
This verson is not intended for general use/review but so Austin can
see my attempt at integrating his regexp tag matching code into the
added/deleted code. However, of course, comments from anyone else are
gratefully received.
Patch 1/7 is basically Austin's patch
id:1392226351-31440-1-git-send-email-amdragon@mit.edu with a small
bugfix. Patches 2-7 are the updated version of
id:1390087855-26194-1-git-send-email-markwalters1009@gmail.com
There are three comments for Patch 4 (the key one of 2-7). First I use
(cons 'deleted/'added/nil tag) as the key for the hashtable
lookup. Secondly the deleted/added tag formatting is now applied on
top of the normal tag formatting (as suggested by Austin). Thirdly:
this has one slightly tricky corner case: a user could hide the tag
normally but want it shown when deleted. This has to be special cased
in the code the avoid applying e.g. propertize to the output of the
first stage formatting: namely nil. A possible alternative would be to
treat all empty-strings as "omit this tag" but I am not sure what
things like images look like to emacs.
Best wishes
Mark
Austin Clements (1):
Make keys of notmuch-tag-formats regexps and use caching
Mark Walters (6):
emacs: tag split customise option for format-tags into a widget
emacs: tag: add customize for deleted/added tag formats
emacs: show: mark tags changed since buffer loaded
emacs: show: use orig-tags for tag display
emacs: search: use orig-tags in search
emacs: tree: use orig-tags in search
emacs/notmuch-show.el | 6 +-
emacs/notmuch-tag.el | 186 ++++++++++++++++++++++++++++++++++++++-----------
emacs/notmuch-tree.el | 9 ++-
emacs/notmuch.el | 40 ++++++----
test/test-lib.el | 5 ++
5 files changed, 184 insertions(+), 62 deletions(-)
--
1.7.9.1
next reply other threads:[~2014-02-14 9:15 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-14 9:15 Mark Walters [this message]
2014-02-14 9:15 ` [WIP Patch 1/7] Make keys of notmuch-tag-formats regexps and use caching Mark Walters
2014-02-14 9:15 ` [WIP Patch 2/7] emacs: tag split customise option for format-tags into a widget Mark Walters
2014-02-14 9:15 ` [WIP Patch 3/7] emacs: tag: add customize for deleted/added tag formats Mark Walters
2014-02-14 9:15 ` [WIP Patch 4/7] emacs: show: mark tags changed since buffer loaded Mark Walters
2014-02-14 9:15 ` [WIP Patch 5/7] emacs: show: use orig-tags for tag display Mark Walters
2014-02-14 9:15 ` [WIP Patch 6/7] emacs: search: use orig-tags in search Mark Walters
2014-02-14 9:15 ` [WIP Patch 7/7] emacs: tree: " Mark Walters
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1392369319-24508-1-git-send-email-markwalters1009@gmail.com \
--to=markwalters1009@gmail.com \
--cc=amdragon@MIT.EDU \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).