[PATCH] test: add basic tests for notmuch new --quiet option

[PATCH] test: add basic tests for notmuch new --quiet option

[Jani Nikula]

This does not cover all the possible paths notmuch new could output
stuff, but it's better than nothing.
---
 test/T050-new.sh | 15 +++++++++++++++
 1 file changed, 15 insertions(+)

diff --git a/test/T050-new.sh b/test/T050-new.sh
index f27423d..b7668ff 100755
--- a/test/T050-new.sh
+++ b/test/T050-new.sh
@@ -248,4 +248,19 @@ ln -s i_do_not_exist "${MAIL_DIR}"/broken_link
 output=$(NOTMUCH_NEW 2>&1)
 test_expect_equal "$output" "No new mail."
 
+test_begin_subtest "Quiet: No new mail."
+output=$(NOTMUCH_NEW --quiet)
+test_expect_equal "$output" ""
+
+test_begin_subtest "Quiet: new, removed and renamed messages."
+# new
+generate_message
+# deleted
+notmuch search --format=text0 --output=files --limit=1 '*' | xargs -0 rm
+# moved
+mkdir "${MAIL_DIR}"/moved_messages
+notmuch search --format=text0 --output=files --offset=1 --limit=1 '*' | xargs -0 -I {} mv {} "${MAIL_DIR}"/moved_messages
+output=$(NOTMUCH_NEW --quiet)
+test_expect_equal "$output" ""
+
 test_done
-- 
1.8.5.2

Re: [PATCH] test: add basic tests for notmuch new --quiet option

[Mark Walters]

LGTM +1.

Best wishes

Mark


On Sun, 26 Jan 2014, Jani Nikula <jani@nikula.org> wrote:
> This does not cover all the possible paths notmuch new could output
> stuff, but it's better than nothing.
> ---
>  test/T050-new.sh | 15 +++++++++++++++
>  1 file changed, 15 insertions(+)
>
> diff --git a/test/T050-new.sh b/test/T050-new.sh
> index f27423d..b7668ff 100755
> --- a/test/T050-new.sh
> +++ b/test/T050-new.sh
> @@ -248,4 +248,19 @@ ln -s i_do_not_exist "${MAIL_DIR}"/broken_link
>  output=$(NOTMUCH_NEW 2>&1)
>  test_expect_equal "$output" "No new mail."
>  
> +test_begin_subtest "Quiet: No new mail."
> +output=$(NOTMUCH_NEW --quiet)
> +test_expect_equal "$output" ""
> +
> +test_begin_subtest "Quiet: new, removed and renamed messages."
> +# new
> +generate_message
> +# deleted
> +notmuch search --format=text0 --output=files --limit=1 '*' | xargs -0 rm
> +# moved
> +mkdir "${MAIL_DIR}"/moved_messages
> +notmuch search --format=text0 --output=files --offset=1 --limit=1 '*' | xargs -0 -I {} mv {} "${MAIL_DIR}"/moved_messages
> +output=$(NOTMUCH_NEW --quiet)
> +test_expect_equal "$output" ""
> +
>  test_done
> -- 
> 1.8.5.2
>
> _______________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org
> http://notmuchmail.org/mailman/listinfo/notmuch

Re: [PATCH] test: add basic tests for notmuch new --quiet option

[Tomi Ollila]

On Sun, Jan 26 2014, Jani Nikula <jani@nikula.org> wrote:

> This does not cover all the possible paths notmuch new could output
> stuff, but it's better than nothing.
> ---

LGTM.

Tomi


>  test/T050-new.sh | 15 +++++++++++++++
>  1 file changed, 15 insertions(+)
>
> diff --git a/test/T050-new.sh b/test/T050-new.sh
> index f27423d..b7668ff 100755
> --- a/test/T050-new.sh
> +++ b/test/T050-new.sh
> @@ -248,4 +248,19 @@ ln -s i_do_not_exist "${MAIL_DIR}"/broken_link
>  output=$(NOTMUCH_NEW 2>&1)
>  test_expect_equal "$output" "No new mail."
>  
> +test_begin_subtest "Quiet: No new mail."
> +output=$(NOTMUCH_NEW --quiet)
> +test_expect_equal "$output" ""
> +
> +test_begin_subtest "Quiet: new, removed and renamed messages."
> +# new
> +generate_message
> +# deleted
> +notmuch search --format=text0 --output=files --limit=1 '*' | xargs -0 rm
> +# moved
> +mkdir "${MAIL_DIR}"/moved_messages
> +notmuch search --format=text0 --output=files --offset=1 --limit=1 '*' | xargs -0 -I {} mv {} "${MAIL_DIR}"/moved_messages
> +output=$(NOTMUCH_NEW --quiet)
> +test_expect_equal "$output" ""
> +
>  test_done
> -- 
> 1.8.5.2
>
> _______________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org
> http://notmuchmail.org/mailman/listinfo/notmuch

Re: [PATCH] test: add basic tests for notmuch new --quiet option

[David Bremner]

Jani Nikula <jani@nikula.org> writes:

> This does not cover all the possible paths notmuch new could output
> stuff, but it's better than nothing.

pushed. really, honest.

d