* [PATCH] test: add test for syntax of emacs test library
@ 2014-01-12 0:10 David Bremner
2014-01-12 9:56 ` Tomi Ollila
2014-01-13 18:37 ` David Bremner
0 siblings, 2 replies; 3+ messages in thread
From: David Bremner @ 2014-01-12 0:10 UTC (permalink / raw)
To: notmuch
If there is a syntax error in the emacs test library, it causes other
tests to hang or crash without a useful error message.
This test could be eliminated if the error reporting for emacs tests
was somehow improved.
---
test/emacs | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/test/emacs b/test/emacs
index 863219d..7dc9a8e 100755
--- a/test/emacs
+++ b/test/emacs
@@ -7,6 +7,10 @@ EXPECTED=$TEST_DIRECTORY/emacs.expected-output
add_email_corpus
+# syntax errors in test-lib.el cause mysterious failures
+test_expect_success 'Syntax of emacs test library' \
+ "${TEST_EMACS} -Q --batch --load $TEST_DIRECTORY/test-lib.el"
+
test_begin_subtest "Basic notmuch-hello view in emacs"
test_emacs '(notmuch-hello)
(test-output)'
--
1.8.5.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] test: add test for syntax of emacs test library
2014-01-12 0:10 [PATCH] test: add test for syntax of emacs test library David Bremner
@ 2014-01-12 9:56 ` Tomi Ollila
2014-01-13 18:37 ` David Bremner
1 sibling, 0 replies; 3+ messages in thread
From: Tomi Ollila @ 2014-01-12 9:56 UTC (permalink / raw)
To: David Bremner, notmuch
On Sun, Jan 12 2014, David Bremner <david@tethera.net> wrote:
> If there is a syntax error in the emacs test library, it causes other
> tests to hang or crash without a useful error message.
>
> This test could be eliminated if the error reporting for emacs tests
> was somehow improved.
> ---
This helps developers to deal with some mysteries in the test suite so LGTM.
Tomi
> test/emacs | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/test/emacs b/test/emacs
> index 863219d..7dc9a8e 100755
> --- a/test/emacs
> +++ b/test/emacs
> @@ -7,6 +7,10 @@ EXPECTED=$TEST_DIRECTORY/emacs.expected-output
>
> add_email_corpus
>
> +# syntax errors in test-lib.el cause mysterious failures
> +test_expect_success 'Syntax of emacs test library' \
> + "${TEST_EMACS} -Q --batch --load $TEST_DIRECTORY/test-lib.el"
> +
> test_begin_subtest "Basic notmuch-hello view in emacs"
> test_emacs '(notmuch-hello)
> (test-output)'
> --
> 1.8.5.2
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] test: add test for syntax of emacs test library
2014-01-12 0:10 [PATCH] test: add test for syntax of emacs test library David Bremner
2014-01-12 9:56 ` Tomi Ollila
@ 2014-01-13 18:37 ` David Bremner
1 sibling, 0 replies; 3+ messages in thread
From: David Bremner @ 2014-01-13 18:37 UTC (permalink / raw)
To: notmuch
David Bremner <david@tethera.net> writes:
> If there is a syntax error in the emacs test library, it causes other
> tests to hang or crash without a useful error message.
>
> This test could be eliminated if the error reporting for emacs tests
> was somehow improved.
pushed, and git even figured out what file to patch despite Tomi's best
efforts ;).
d
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-01-13 18:37 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-01-12 0:10 [PATCH] test: add test for syntax of emacs test library David Bremner
2014-01-12 9:56 ` Tomi Ollila
2014-01-13 18:37 ` David Bremner
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).