From: David Bremner <david@tethera.net>
To: notmuch@notmuchmail.org
Subject: [PATCH] test/emacs: replace the use of process-attributes with signal-process
Date: Sat, 11 Jan 2014 13:25:39 -0400 [thread overview]
Message-ID: <1389461139-20249-1-git-send-email-david@tethera.net> (raw)
In-Reply-To: <m2bnziygdu.fsf@guru.guru-group.fi>
In some environments (at least Hurd), process-attributes is
unimplimented and always returns nil. This ends up causing test
failures (see e.g. id:87a9ffofsc.fsf@zancas.localnet).
Historically and according to POSIX 1003.1-2001, a signal of 0 can be
used to check the validity of a pid. This seems less heinous than
parsing the output of ps(1).
---
Thanks to Domo for the simpler solution. Now that I think about it,
perhaps this makes sense as a debian only update, since it currently
fails only on Debian/Hurd, which according to the GNU project is the
only "working distribution
test/test-lib.el | 15 +++++++++------
1 file changed, 9 insertions(+), 6 deletions(-)
diff --git a/test/test-lib.el b/test/test-lib.el
index d26b49f..37fcb3d 100644
--- a/test/test-lib.el
+++ b/test/test-lib.el
@@ -77,19 +77,22 @@ invisible text."
(setq start next-pos)))
str))
+;; process-attributes is not defined everywhere, so define an
+;; alternate way to test if a process still exists.
+
+(defun test-process-running (pid)
+ (= 0
+ (signal-process pid 0)))
+
(defun orphan-watchdog-check (pid)
"Periodically check that the process with id PID is still
running, quit if it terminated."
- (if (not (process-attributes pid))
+ (if (not (test-process-running pid))
(kill-emacs)))
(defun orphan-watchdog (pid)
"Initiate orphan watchdog check."
- ; If process-attributes returns nil right away, that probably means
- ; it is unimplimented. So we delay two minutes before killing emacs.
- (if (process-attributes pid)
- (run-at-time 60 60 'orphan-watchdog-check pid)
- (run-at-time 120 60 'orphan-watchdog-check pid)))
+ (run-at-time 60 60 'orphan-watchdog-check pid))
(defun hook-counter (hook)
"Count how many times a hook is called. Increments
--
1.8.5.2
next prev parent reply other threads:[~2014-01-11 17:25 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-29 23:26 another bug fix release: 0.15.2, in progress david
2013-01-29 23:26 ` [PATCH 1/2] test: delay watchdog checks in emacs david
2014-01-01 15:58 ` David Bremner
2014-01-11 2:36 ` [PATCH] test/emacs: replace the use of process-attributes with kill(1) David Bremner
2014-01-11 10:14 ` Tomi Ollila
2014-01-11 17:25 ` David Bremner [this message]
2014-01-11 18:50 ` [PATCH] test/emacs: replace the use of process-attributes with signal-process Tomi Ollila
2014-01-13 0:09 ` David Bremner
2013-01-29 23:26 ` [PATCH 2/2] NEWS: News for 0.15.2 david
2013-01-30 0:37 ` another bug fix release: 0.15.2, in progress Tomi Ollila
2013-02-10 1:17 ` David Bremner
2013-02-10 13:19 ` [Spam-verdenking][english 100%] " Robert Mast
2013-02-10 13:44 ` David Bremner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1389461139-20249-1-git-send-email-david@tethera.net \
--to=david@tethera.net \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).