From: Mark Walters <markwalters1009@gmail.com>
To: notmuch@notmuchmail.org
Subject: [PATCH v2 1/5] test: make test_emacs call post-command-hook
Date: Sat, 14 Dec 2013 23:53:13 +0000 [thread overview]
Message-ID: <1387065197-15776-2-git-send-email-markwalters1009@gmail.com> (raw)
In-Reply-To: <1387065197-15776-1-git-send-email-markwalters1009@gmail.com>
The unread/read changes will use the post-command-hook. test_emacs
does not call the post-command-hook. This adds a notmuch-test-progn
which takes a list of commands as argument and executes them in turn
but runs the post-command-hook after each one.
The caller can batch operations (ie to stop post-command-hook from
being interleaved) by wrapping the batch of operations inside a progn.
We also explicitly run the post-command-hook before getting the output
from a test; this makes sense as this will be a place the user would
be seeing the information.
---
test/test-lib.el | 12 ++++++++++++
test/test-lib.sh | 2 +-
2 files changed, 13 insertions(+), 1 deletions(-)
diff --git a/test/test-lib.el b/test/test-lib.el
index d26b49f..1c9e224 100644
--- a/test/test-lib.el
+++ b/test/test-lib.el
@@ -52,11 +52,13 @@
(defun test-output (&optional filename)
"Save current buffer to file FILENAME. Default FILENAME is OUTPUT."
+ (notmuch-post-command)
(write-region (point-min) (point-max) (or filename "OUTPUT")))
(defun test-visible-output (&optional filename)
"Save visible text in current buffer to file FILENAME. Default
FILENAME is OUTPUT."
+ (notmuch-post-command)
(let ((text (visible-buffer-string)))
(with-temp-file (or filename "OUTPUT") (insert text))))
@@ -162,3 +164,13 @@ nothing."
(t
(notmuch-test-report-unexpected output expected)))))
+
+(defun notmuch-post-command ()
+ (run-hooks 'post-command-hook))
+
+(defun notmuch-test-progn (body)
+ (let (form
+ ret)
+ (dolist (form body ret)
+ (setq ret (eval form))
+ (notmuch-post-command))))
diff --git a/test/test-lib.sh b/test/test-lib.sh
index d8e0d91..e7833fc 100644
--- a/test/test-lib.sh
+++ b/test/test-lib.sh
@@ -1075,7 +1075,7 @@ test_emacs () {
rm -f OUTPUT
touch OUTPUT
- ${TEST_EMACSCLIENT} --socket-name="$EMACS_SERVER" --eval "(progn $@)"
+ ${TEST_EMACSCLIENT} --socket-name="$EMACS_SERVER" --eval "(notmuch-test-progn '($@))"
}
test_python() {
--
1.7.9.1
next prev parent reply other threads:[~2013-12-14 23:53 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-14 23:53 [PATCH v2 0/5] emacs: show: redesign unread/read logic Mark Walters
2013-12-14 23:53 ` Mark Walters [this message]
2013-12-14 23:53 ` [PATCH v2 2/5] emacs: tree: make the tree code force the mark read update Mark Walters
2013-12-14 23:53 ` [PATCH v2 3/5] emacs: show: mark tags changed since buffer loaded Mark Walters
2013-12-14 23:53 ` [PATCH v2 4/5] emacs: show: add an update seen function to post-command-hook Mark Walters
2013-12-14 23:53 ` [PATCH v2 5/5] emacs: show: make `seen' mean user viewed whole message Mark Walters
2013-12-19 19:35 ` [PATCH v2 0/5] emacs: show: redesign unread/read logic Mark Walters
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1387065197-15776-2-git-send-email-markwalters1009@gmail.com \
--to=markwalters1009@gmail.com \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).