From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 336EA429E47 for ; Tue, 22 Oct 2013 17:22:28 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: -0.7 X-Spam-Level: X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5 tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Alv4rioNuHIU for ; Tue, 22 Oct 2013 17:22:21 -0700 (PDT) Received: from dmz-mailsec-scanner-2.mit.edu (dmz-mailsec-scanner-2.mit.edu [18.9.25.13]) by olra.theworths.org (Postfix) with ESMTP id A25B4429E28 for ; Tue, 22 Oct 2013 17:22:08 -0700 (PDT) X-AuditID: 1209190d-b7f528e0000009b4-73-526716b0a6d9 Received: from mailhub-auth-1.mit.edu ( [18.9.21.35]) by dmz-mailsec-scanner-2.mit.edu (Symantec Messaging Gateway) with SMTP id 1C.30.02484.0B617625; Tue, 22 Oct 2013 20:22:08 -0400 (EDT) Received: from outgoing.mit.edu (outgoing-auth-1.mit.edu [18.9.28.11]) by mailhub-auth-1.mit.edu (8.13.8/8.9.2) with ESMTP id r9N0M562012255; Tue, 22 Oct 2013 20:22:05 -0400 Received: from drake.dyndns.org (216-15-114-40.c3-0.arl-ubr1.sbo-arl.ma.cable.rcn.com [216.15.114.40]) (authenticated bits=0) (User authenticated as amdragon@ATHENA.MIT.EDU) by outgoing.mit.edu (8.13.8/8.12.4) with ESMTP id r9N0M3LB005835 (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=NOT); Tue, 22 Oct 2013 20:22:04 -0400 Received: from amthrax by drake.dyndns.org with local (Exim 4.77) (envelope-from ) id 1VYmD5-0008KC-FJ; Tue, 22 Oct 2013 20:22:03 -0400 From: Austin Clements To: notmuch@notmuchmail.org Subject: [PATCH v2 1/8] emacs: Fix misuse of `notmuch-tag' Date: Tue, 22 Oct 2013 20:21:54 -0400 Message-Id: <1382487721-31776-2-git-send-email-amdragon@mit.edu> X-Mailer: git-send-email 1.8.4.rc3 In-Reply-To: <1382487721-31776-1-git-send-email-amdragon@mit.edu> References: <1382487721-31776-1-git-send-email-amdragon@mit.edu> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrNIsWRmVeSWpSXmKPExsUixCmqrLtBLD3I4N11CYvVc3ksrt+cyezA 5LFz1l12j2erbjEHMEVx2aSk5mSWpRbp2yVwZcxvnMBeMJWj4tj+J0wNjI/Yuhg5OSQETCRm TJwMZYtJXLi3Hsjm4hAS2Mco8fTtBlYIZyOjxMtLH5kgnDtMEm9WP4YqmwtUtvAJWD+bgIbE tv3LGUFsEQFpiZ13Z7OC2MwCjhKf9y8CquHgEBawkjjWogBisgioSrxeywdSwSvgIHF813d2 iCuUJBae2gbWyQnU+WbHB7DpQkA1U3aeYZnAyL+AkWEVo2xKbpVubmJmTnFqsm5xcmJeXmqR rpFebmaJXmpK6SZGcBhJ8u5gfHdQ6RCjAAejEg+vRXtakBBrYllxZe4hRkkOJiVRXnX+9CAh vqT8lMqMxOKM+KLSnNTiQ4wSHMxKIrzNvkDlvCmJlVWpRfkwKWkOFiVx3psc9kFCAumJJanZ qakFqUUwWRkODiUJXl9RoKGCRanpqRVpmTklCGkmDk6Q4TxAw1eA1PAWFyTmFmemQ+RPMSpK ifPygyQEQBIZpXlwvbA4f8UoDvSKMO8XEaAqHmCKgOt+BTSYCWjwlCUgVxeXJCKkpBoYq8MN j5maBbraX7Av3np88/F7i2Ws/ureDG2aqcMqcuiRQYIwk8f+zR5MZ5Yu5rd/E27Q+PG2B+Oj N2aroh/lJ37a7z/nVf0Oh4pNzFu7i89ybm1S4H4SPb/kYGqYR8Kyh3P9ZFj9V3y7vuSA3K6l zSqB+1deO865UGO16Xd5foENthNdV04/r8RSnJFoqMVcVJwIAG7fbDDOAgAA X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 23 Oct 2013 00:22:28 -0000 The calling convention for `notmuch-tag' changed in commit 97aa3c06 to take a list of tag changes instead of a &rest argument, but the call from `notmuch-search-tag-all' still passed a &rest argument. This happened to work for interactive calls because tag-changes would be nil, so the `apply' call would pass only the query string to `notmuch-tag' and simply omit the &optional tag-changes argument. --- emacs/notmuch.el | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/emacs/notmuch.el b/emacs/notmuch.el index c47c6b5..e0511c8 100644 --- a/emacs/notmuch.el +++ b/emacs/notmuch.el @@ -837,7 +837,7 @@ non-authors is found, assume that all of the authors match." See `notmuch-tag' for information on the format of TAG-CHANGES." (interactive) - (apply 'notmuch-tag notmuch-search-query-string tag-changes)) + (notmuch-tag notmuch-search-query-string tag-changes)) (defun notmuch-search-buffer-title (query) "Returns the title for a buffer with notmuch search results." -- 1.8.4.rc3