From: Austin Clements <amdragon@MIT.EDU>
To: notmuch@notmuchmail.org
Subject: [PATCH 5/8] pick: Fix incorrect use of `notmuch-pick-tag'
Date: Tue, 22 Oct 2013 15:50:54 -0400 [thread overview]
Message-ID: <1382471457-26056-6-git-send-email-amdragon@mit.edu> (raw)
In-Reply-To: <1382471457-26056-1-git-send-email-amdragon@mit.edu>
`notmuch-pick-tag' takes a list of tag changes, but
`notmuch-pick-archive-message' passes it a &rest argument. This
happens to work if `notmuch-archive-tags' contains a single tag (which
it usually does), but will break if it does not.
---
contrib/notmuch-pick/notmuch-pick.el | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/contrib/notmuch-pick/notmuch-pick.el b/contrib/notmuch-pick/notmuch-pick.el
index 0aa651e..8f504ed 100644
--- a/contrib/notmuch-pick/notmuch-pick.el
+++ b/contrib/notmuch-pick/notmuch-pick.el
@@ -542,8 +542,7 @@ message will be \"unarchived\", i.e. the tag changes in
`notmuch-archive-tags' will be reversed."
(interactive "P")
(when notmuch-archive-tags
- (apply 'notmuch-pick-tag
- (notmuch-tag-change-list notmuch-archive-tags unarchive))))
+ (notmuch-pick-tag (notmuch-tag-change-list notmuch-archive-tags unarchive))))
(defun notmuch-pick-archive-message-then-next (&optional unarchive)
"Archive the current message and move to next matching message."
--
1.8.4.rc3
next prev parent reply other threads:[~2013-10-22 19:51 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-22 19:50 [PATCH 0/8] Improve tag change completion Austin Clements
2013-10-22 19:50 ` [PATCH 1/8] emacs: Fix misuse of `notmuch-tag' Austin Clements
2013-10-22 19:50 ` [PATCH 2/8] emacs: Take prompt and current tags in `notmuch-read-tag-changes' Austin Clements
2013-10-22 19:50 ` [PATCH 3/8] emacs: Use interactive specifications for tag changes in show Austin Clements
2013-10-22 19:50 ` [PATCH 4/8] emacs: Use interactive specifications for tag changes in search Austin Clements
2013-10-22 19:50 ` Austin Clements [this message]
2013-10-22 19:50 ` [PATCH 6/8] pick: Use list form of tag-changes in test Austin Clements
2013-10-22 19:50 ` [PATCH 7/8] pick: Use interactive specifications for tag changes Austin Clements
2013-10-22 19:50 ` [PATCH 8/8] emacs: Remove interactive behavior of `notmuch-tag' Austin Clements
2013-11-04 0:42 ` Jameson Graef Rollins
2013-11-12 23:18 ` Austin Clements
2013-10-22 21:43 ` [PATCH 0/8] Improve tag change completion Mark Walters
2013-10-23 0:19 ` Austin Clements
2013-10-23 9:56 ` Mark Walters
2013-10-23 15:44 ` Austin Clements
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1382471457-26056-6-git-send-email-amdragon@mit.edu \
--to=amdragon@mit.edu \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).