unofficial mirror of notmuch@notmuchmail.org
 help / color / mirror / code / Atom feed
* [PATCH] contrib: pick: update notmuch-show calls
@ 2013-10-13  7:49 Mark Walters
  2013-10-14 11:36 ` David Bremner
  0 siblings, 1 reply; 2+ messages in thread
From: Mark Walters @ 2013-10-13  7:49 UTC (permalink / raw)
  To: notmuch

Remove some unneeded nil arguments in notmuch-show calls.
---
This is really a patch on top of
id:1381649952-23122-1-git-send-email-markwalters1009@gmail.com as
passing three nil optional arguments out of four seems untidy. Since
these arguments are superfluous in any case just remove them.


 contrib/notmuch-pick/notmuch-pick.el |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/contrib/notmuch-pick/notmuch-pick.el b/contrib/notmuch-pick/notmuch-pick.el
index 0aa651e..a492214 100644
--- a/contrib/notmuch-pick/notmuch-pick.el
+++ b/contrib/notmuch-pick/notmuch-pick.el
@@ -461,7 +461,7 @@ Does NOT change the database."
 	;; Since we are only displaying one message do not indent.
 	(let ((notmuch-show-indent-messages-width 0)
 	      (notmuch-show-only-matching-messages t))
-	  (setq buffer (notmuch-show id nil nil nil))))
+	  (setq buffer (notmuch-show id))))
       ;; We need the `let' as notmuch-pick-message-window is buffer local.
       (let ((window notmuch-pick-message-window))
 	(with-current-buffer buffer
@@ -480,7 +480,7 @@ Does NOT change the database."
     (when id
       ;; We close the window to kill off un-needed buffers.
       (notmuch-pick-close-message-window)
-      (notmuch-show id nil nil nil))))
+      (notmuch-show id))))
 
 (defun notmuch-pick-show-message (arg)
   "Show the current message.
-- 
1.7.9.1

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] contrib: pick: update notmuch-show calls
  2013-10-13  7:49 [PATCH] contrib: pick: update notmuch-show calls Mark Walters
@ 2013-10-14 11:36 ` David Bremner
  0 siblings, 0 replies; 2+ messages in thread
From: David Bremner @ 2013-10-14 11:36 UTC (permalink / raw)
  To: Mark Walters, notmuch

Mark Walters <markwalters1009@gmail.com> writes:

> Remove some unneeded nil arguments in notmuch-show calls.

pushed.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2013-10-14 11:36 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-10-13  7:49 [PATCH] contrib: pick: update notmuch-show calls Mark Walters
2013-10-14 11:36 ` David Bremner

Code repositories for project(s) associated with this public inbox

	https://yhetil.org/notmuch.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).