From: Mark Walters <markwalters1009@gmail.com>
To: notmuch@notmuchmail.org
Subject: [PATCH] test: set mail host in emacs_deliver
Date: Sat, 12 Oct 2013 08:36:30 +0100 [thread overview]
Message-ID: <1381563390-19457-1-git-send-email-markwalters1009@gmail.com> (raw)
One test (reply to encrypted message in the crypto test) recently
started failing on some systems. The failure I saw were two extra
lines of the form
<87d2nbc5xg.fsf@host.i-did-not-set--mail-host-address--so-tickle-me>
The test pipes the output through
grep -v -e '^In-Reply-To:' -e '^References:'
which would normally these two ids but it does not, in this case,
because they are so long they get put on a separate line in the output.
To fix this we set mail-host-address for emacs deliver. example.com
seems a sensible address to use. This is short enough that we don't
get the line breaks above and the tests then all pass.
---
I don't know when this test started failing: I tried to bisect and it
went back quite a long way on machines which I thought had been
passing the tests. (It does look like things outside notmuch might
make some differences though so maybe this is not surprising)
Best wishes
Mark
test/test-lib.sh | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/test/test-lib.sh b/test/test-lib.sh
index d3a8c58..2aa4dfc 100644
--- a/test/test-lib.sh
+++ b/test/test-lib.sh
@@ -445,6 +445,7 @@ emacs_deliver_message ()
test_emacs \
"(let ((message-send-mail-function 'message-smtpmail-send-it)
+ (mail-host-address \"example.com\")
(smtpmail-smtp-server \"localhost\")
(smtpmail-smtp-service \"25025\"))
(notmuch-hello)
--
1.7.9.1
next reply other threads:[~2013-10-12 7:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-12 7:36 Mark Walters [this message]
2013-10-14 11:36 ` [PATCH] test: set mail host in emacs_deliver David Bremner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1381563390-19457-1-git-send-email-markwalters1009@gmail.com \
--to=markwalters1009@gmail.com \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).