unofficial mirror of notmuch@notmuchmail.org
 help / color / mirror / code / Atom feed
From: "Tomi.Ollila" <tomi.ollila@iki.fi>
To: notmuch@notmuchmail.org
Cc: tomi.ollila@iki.fi
Subject: [PATCH 1/1] emacs: fix notmuch-mua-reply point placement when signature involved
Date: Wed,  4 Sep 2013 22:20:58 +0300	[thread overview]
Message-ID: <1378322458-30159-1-git-send-email-tomi.ollila@iki.fi> (raw)

From: Tomi Ollila <tomi.ollila@iki.fi>

When composing a reply, notmuch-mua-reply attempts to  cite the
the original message by inserting it before the user signature, if
one is present. The existing method used to search the signature
separator backward from the end of the buffer and then move one
line up. In case of variable `message-signature-insert-empty-line'
being nil (and `message-signature-setup-hook' not intervening) this
caused point to go to the beginning of '--text follows this line--'
separator line, and citation was inserted there.
This change checks the value of `message-signature-insert-empty-line'
and doesn't move point if that is nil. Additional narrowing to
the body region ensures that point never goes to the separator line
(or beyond).

Original patch from "Geoffrey H. Ferrari", continued with iterations
from Jani and Mark.
---
 emacs/notmuch-mua.el | 12 ++++++++----
 1 file changed, 8 insertions(+), 4 deletions(-)

diff --git a/emacs/notmuch-mua.el b/emacs/notmuch-mua.el
index 2baae5f..0280c9f 100644
--- a/emacs/notmuch-mua.el
+++ b/emacs/notmuch-mua.el
@@ -192,10 +192,14 @@ list."
 
       ;; Insert the message body - but put it in front of the signature
       ;; if one is present
-      (goto-char (point-max))
-      (if (re-search-backward message-signature-separator nil t)
-	  (forward-line -1)
-	(goto-char (point-max)))
+      (save-restriction
+	(message-goto-body)
+	(narrow-to-region (point) (point-max))
+	(goto-char (point-max))
+	(if (re-search-backward message-signature-separator nil t)
+	    (if message-signature-insert-empty-line
+		(forward-line -1))
+	  (goto-char (point-max))))
 
       (let ((from (plist-get original-headers :From))
 	    (date (plist-get original-headers :Date))
-- 
1.8.0

             reply	other threads:[~2013-09-04 19:21 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-04 19:20 Tomi.Ollila [this message]
2013-09-05  9:19 ` [PATCH 1/1] emacs: fix notmuch-mua-reply point placement when signature involved Mark Walters
2013-09-05 14:11 ` Jani Nikula
2013-09-05 14:22   ` Tomi Ollila
2013-09-05 16:42     ` Jani Nikula
  -- strict thread matches above, loose matches on Subject: below --
2013-09-06 14:32 Tomi Ollila
2013-09-06 17:16 ` Mark Walters
2013-09-09  1:53 ` David Bremner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://notmuchmail.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1378322458-30159-1-git-send-email-tomi.ollila@iki.fi \
    --to=tomi.ollila@iki.fi \
    --cc=notmuch@notmuchmail.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://yhetil.org/notmuch.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).