unofficial mirror of notmuch@notmuchmail.org
 help / color / mirror / code / Atom feed
From: Austin Clements <amdragon@MIT.EDU>
To: notmuch@notmuchmail.org
Subject: [PATCH v2 1/9] emacs: Consistently use configured sort order
Date: Tue,  3 Sep 2013 17:45:17 -0400	[thread overview]
Message-ID: <1378244725-18846-2-git-send-email-amdragon@mit.edu> (raw)
In-Reply-To: <1378244725-18846-1-git-send-email-amdragon@mit.edu>

Previously, if `notmuch-search' was called interactively (bound to "s"
in search and show, but not hello), it would always use newest-first.
However, `notmuch-hello-search' (bound to "s" in hello) and
`notmuch-hello-widget-search` would call it with the user-configured
sort order.  This inconsistency seems unintentional, so change
`notmuch-search' to use the user-configured sort order when called
interactively.
---
 emacs/notmuch.el |   14 ++++++++++++--
 1 file changed, 12 insertions(+), 2 deletions(-)

diff --git a/emacs/notmuch.el b/emacs/notmuch.el
index f3ce840..c964186 100644
--- a/emacs/notmuch.el
+++ b/emacs/notmuch.el
@@ -906,8 +906,18 @@ Other optional parameters are used as follows:
   target-thread: A thread ID (without the thread: prefix) that will be made
                  current if it appears in the search results.
   target-line: The line number to move to if the target thread does not
-               appear in the search results."
-  (interactive)
+               appear in the search results.
+
+When called interactively, this will prompt for a query and use
+the configured default sort order."
+  (interactive
+   (list
+    ;; Prompt for a query
+    nil
+    ;; Use the default search order (if we're doing a search from a
+    ;; search buffer, ignore any buffer-local overrides)
+    (default-value notmuch-search-oldest-first)))
+
   (let* ((query (or query (notmuch-read-query "Notmuch search: ")))
 	 (buffer (get-buffer-create (notmuch-search-buffer-title query))))
     (switch-to-buffer buffer)
-- 
1.7.10.4

  reply	other threads:[~2013-09-03 21:45 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-03 21:45 [PATCH v2 0/9] emacs: Unify common key bindings and lots more Austin Clements
2013-09-03 21:45 ` Austin Clements [this message]
2013-09-03 21:45 ` [PATCH v2 2/9] emacs: Refresh hello whenever the user switches to the buffer Austin Clements
2013-09-03 21:45 ` [PATCH v2 3/9] emacs: Bind "s" to notmuch-search in hello-mode Austin Clements
2013-09-03 21:45 ` [PATCH v2 4/9] emacs: Remove notmuch-search quit continuation Austin Clements
2013-09-03 21:45 ` [PATCH v2 5/9] emacs: Move `notmuch-poll' to notmuch-lib Austin Clements
2013-09-03 21:45 ` [PATCH v2 6/9] emacs: Add unified refresh-this-buffer function Austin Clements
2013-09-03 21:45 ` [PATCH v2 7/9] emacs: Make notmuch-help work with arbitrary keymaps Austin Clements
2013-09-03 21:45 ` [PATCH v2 8/9] emacs: Define a common shared keymap for all of notmuch Austin Clements
2013-09-03 21:45 ` [PATCH v2 9/9] emacs: Move ?, q, s, m, =, and G to the common keymap Austin Clements
2013-09-05  9:27 ` [PATCH v2 0/9] emacs: Unify common key bindings and lots more Mark Walters
2013-09-09 16:59 ` Tomi Ollila
2013-09-10 11:15 ` David Bremner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://notmuchmail.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1378244725-18846-2-git-send-email-amdragon@mit.edu \
    --to=amdragon@mit.edu \
    --cc=notmuch@notmuchmail.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://yhetil.org/notmuch.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).