From: Mark Walters <markwalters1009@gmail.com>
To: notmuch@notmuchmail.org
Subject: [Patch v3 1/3] contrib: pick: remove unneeded variable notmuch-pick-buffer-name
Date: Mon, 2 Sep 2013 21:15:12 +0100 [thread overview]
Message-ID: <1378152914-18930-2-git-send-email-markwalters1009@gmail.com> (raw)
In-Reply-To: <1378152914-18930-1-git-send-email-markwalters1009@gmail.com>
This variable is essentially unused: it was only used for making sure
it itself got reset after a refresh of the buffer.
It did this by passing an unnecessary argument to notmuch-pick-worker
so remove that too.
---
contrib/notmuch-pick/notmuch-pick.el | 25 +++++++++----------------
1 files changed, 9 insertions(+), 16 deletions(-)
diff --git a/contrib/notmuch-pick/notmuch-pick.el b/contrib/notmuch-pick/notmuch-pick.el
index f7caaa8..32bd6b5 100644
--- a/contrib/notmuch-pick/notmuch-pick.el
+++ b/contrib/notmuch-pick/notmuch-pick.el
@@ -161,10 +161,6 @@
"A buffer local copy of argument open-target to the function notmuch-pick")
(make-variable-buffer-local 'notmuch-pick-open-target)
-(defvar notmuch-pick-buffer-name nil
- "A buffer local copy of argument buffer-name to the function notmuch-pick")
-(make-variable-buffer-local 'notmuch-pick-buffer-name)
-
(defvar notmuch-pick-message-window nil
"The window of the message pane.
@@ -590,13 +586,11 @@ message will be \"unarchived\", i.e. the tag changes in
(let ((inhibit-read-only t)
(basic-query notmuch-pick-basic-query)
(query-context notmuch-pick-query-context)
- (target (notmuch-pick-get-message-id))
- (buffer-name notmuch-pick-buffer-name))
+ (target (notmuch-pick-get-message-id)))
(erase-buffer)
(notmuch-pick-worker basic-query
query-context
- target
- (get-buffer buffer-name))))
+ target)))
(defun notmuch-pick-thread-top ()
(when (notmuch-pick-get-message-properties)
@@ -859,12 +853,11 @@ Complete list of currently available key bindings:
(notmuch-sexp-parse-partial-list 'notmuch-pick-insert-forest-thread
results-buf)))))
-(defun notmuch-pick-worker (basic-query &optional query-context target buffer open-target)
+(defun notmuch-pick-worker (basic-query &optional query-context target open-target)
(interactive)
(notmuch-pick-mode)
(setq notmuch-pick-basic-query basic-query)
(setq notmuch-pick-query-context query-context)
- (setq notmuch-pick-buffer-name (buffer-name buffer))
(setq notmuch-pick-target-msg target)
(setq notmuch-pick-open-target open-target)
@@ -877,7 +870,7 @@ Complete list of currently available key bindings:
(if (equal (car (process-lines notmuch-command "count" search-args)) "0")
(setq search-args basic-query))
(let ((proc (notmuch-start-notmuch
- "notmuch-pick" buffer #'notmuch-pick-process-sentinel
+ "notmuch-pick" (current-buffer) #'notmuch-pick-process-sentinel
"show" "--body=false" "--format=sexp"
message-arg search-args))
;; Use a scratch buffer to accumulate partial output.
@@ -910,13 +903,13 @@ The arguments are:
(concat "*notmuch-pick-" query "*")))))
(inhibit-read-only t))
- (switch-to-buffer buffer)
- ;; Don't track undo information for this buffer
- (set 'buffer-undo-list t)
+ (switch-to-buffer buffer))
+ ;; Don't track undo information for this buffer
+ (set 'buffer-undo-list t)
- (notmuch-pick-worker query query-context target buffer open-target)
+ (notmuch-pick-worker query query-context target open-target)
- (setq truncate-lines t)))
+ (setq truncate-lines t))
;; Set up key bindings from the rest of notmuch.
--
1.7.9.1
next prev parent reply other threads:[~2013-09-02 20:15 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-02 20:15 [Patch v3 0/3] contrib: pick: remove an unused variable Mark Walters
2013-09-02 20:15 ` Mark Walters [this message]
2013-09-02 20:15 ` [Patch v3 2/3] contrib: pick: add docstring for notmuch-pick-worker Mark Walters
2013-09-02 20:15 ` [Patch v3 3/3] contrib: pick: test: refresh view Mark Walters
2013-09-03 9:20 ` [Patch v3 0/3] contrib: pick: remove an unused variable David Bremner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1378152914-18930-2-git-send-email-markwalters1009@gmail.com \
--to=markwalters1009@gmail.com \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).