unofficial mirror of notmuch@notmuchmail.org
 help / color / mirror / code / Atom feed
From: Christopher Wellons <wellons@nullprogram.com>
To: notmuch@notmuchmail.org
Cc: Christopher Wellons <wellons@nullprogram.com>
Subject: [PATCH] Switch to DEF from INITIAL-INPUT in completing-read.
Date: Wed, 21 Aug 2013 12:44:48 -0400	[thread overview]
Message-ID: <1377103488-7425-1-git-send-email-wellons@nullprogram.com> (raw)

As stated in the Emacs documentation, the initial-input argument is
deprecated because it presents a poor interface to the user. In fact,
with my setup where ido replaces completing-read, it's nearly unusable
with initial-input.

http://www.gnu.org/software/emacs/manual/html_node/elisp/Initial-Input.html
---
 emacs/notmuch-address.el | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/emacs/notmuch-address.el b/emacs/notmuch-address.el
index fa65cd5..e89200b 100644
--- a/emacs/notmuch-address.el
+++ b/emacs/notmuch-address.el
@@ -42,11 +42,11 @@ to know how address selection is made by default."
   :group 'notmuch-send
   :group 'notmuch-external)
 
-(defun notmuch-address-selection-function (prompt collection initial-input)
+(defun notmuch-address-selection-function (prompt collection def)
   "Call (`completing-read'
-      PROMPT COLLECTION nil nil INITIAL-INPUT 'notmuch-address-history)"
+      PROMPT COLLECTION nil nil nil 'notmuch-address-history DEF)"
   (completing-read
-   prompt collection nil nil initial-input 'notmuch-address-history))
+   prompt collection nil nil nil 'notmuch-address-history def))
 
 (defvar notmuch-address-message-alist-member
   '("^\\(Resent-\\)?\\(To\\|B?Cc\\|Reply-To\\|From\\|Mail-Followup-To\\|Mail-Copies-To\\):"
-- 
1.8.4.rc3

             reply	other threads:[~2013-08-21 17:08 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-21 16:44 Christopher Wellons [this message]
2013-08-21 19:19 ` [PATCH] Switch to DEF from INITIAL-INPUT in completing-read Tomi Ollila
2013-08-22 17:08   ` Tomi Ollila
2013-08-23  2:11     ` Christopher Wellons
2013-08-24  7:18       ` Tomi Ollila

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://notmuchmail.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1377103488-7425-1-git-send-email-wellons@nullprogram.com \
    --to=wellons@nullprogram.com \
    --cc=notmuch@notmuchmail.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://yhetil.org/notmuch.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).