unofficial mirror of notmuch@notmuchmail.org
 help / color / mirror / code / Atom feed
From: Geoffrey Ferrari <geoffrey.ferrari@oriel.oxon.org>
To: notmuch@notmuchmail.org
Cc: "Geoffrey H. Ferrari" <geoffrey.ferrari@oriel.oxon.org>
Subject: [PATCH] emacs: bugfix notmuch-mua-reply when signature is present
Date: Thu,  8 Aug 2013 12:35:32 +0100	[thread overview]
Message-ID: <1375961732-14327-1-git-send-email-geoffrey.ferrari@oriel.oxon.org> (raw)

From: "Geoffrey H. Ferrari" <geoffrey.ferrari@oriel.oxon.org>

When composing a reply, notmuch-mua-reply tries to be smart and cite
the original message by inserting it before the user signature, if
one is present. However, the existing method of backward searching
from the end of the buffer to find the signature separator and then
moving one line up results in the original message being cited in
the message headers. That's because at this point the message looks
like this (with | representing point after searching for the
signature separator):

From: xxx
To: xxx
Subject: xxx
--text follows this line--
|--
My fancy signature

With this patch, a newline is opened instead, so that the orignal
message is cited above the signature but still in the message text.
---
 emacs/notmuch-mua.el |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/emacs/notmuch-mua.el b/emacs/notmuch-mua.el
index 2baae5f..86f164d 100644
--- a/emacs/notmuch-mua.el
+++ b/emacs/notmuch-mua.el
@@ -194,7 +194,7 @@ list."
       ;; if one is present
       (goto-char (point-max))
       (if (re-search-backward message-signature-separator nil t)
-	  (forward-line -1)
+	  (newline)
 	(goto-char (point-max)))
 
       (let ((from (plist-get original-headers :From))
-- 
1.7.10.4

             reply	other threads:[~2013-08-08 20:30 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-08 11:35 Geoffrey Ferrari [this message]
2013-08-09  8:19 ` [PATCH] emacs: bugfix notmuch-mua-reply when signature is present Tomi Ollila
2013-08-19 14:29   ` Tomi Ollila
2013-08-26 17:58     ` Jani Nikula
2013-08-28 17:31 ` Tomi Ollila
2013-08-28 18:53   ` Tomi Ollila
2013-08-28 19:37     ` Jani Nikula
2013-08-28 20:14       ` Jani Nikula
2013-08-28 20:46       ` Tomi Ollila

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://notmuchmail.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1375961732-14327-1-git-send-email-geoffrey.ferrari@oriel.oxon.org \
    --to=geoffrey.ferrari@oriel.oxon.org \
    --cc=notmuch@notmuchmail.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://yhetil.org/notmuch.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).