From: Mark Walters <markwalters1009@gmail.com>
To: notmuch@notmuchmail.org
Subject: [PATCH 02/11] contrib: pick: Link in notmuch-show-pipe-message
Date: Fri, 5 Jul 2013 19:11:09 +0100 [thread overview]
Message-ID: <1373047878-20822-3-git-send-email-markwalters1009@gmail.com> (raw)
In-Reply-To: <1373047878-20822-1-git-send-email-markwalters1009@gmail.com>
Since we can now use show functions directly in pick we can drop pick-pipe-message.
---
contrib/notmuch-pick/notmuch-pick.el | 33 ++++-----------------------------
1 files changed, 4 insertions(+), 29 deletions(-)
diff --git a/contrib/notmuch-pick/notmuch-pick.el b/contrib/notmuch-pick/notmuch-pick.el
index d07f393..08bdc11 100644
--- a/contrib/notmuch-pick/notmuch-pick.el
+++ b/contrib/notmuch-pick/notmuch-pick.el
@@ -190,6 +190,10 @@ if the user has loaded a different buffer in that window.")
(defvar notmuch-pick-mode-map
(let ((map (make-sparse-keymap)))
(define-key map [mouse-1] 'notmuch-pick-show-message)
+ ;; these use notmuch-show functions directly
+ (define-key map "|" 'notmuch-show-pipe-message)
+
+ ;; The main pick bindings
(define-key map "q" 'notmuch-pick-quit)
(define-key map "x" 'notmuch-pick-quit)
(define-key map "?" 'notmuch-help)
@@ -205,7 +209,6 @@ if the user has loaded a different buffer in that window.")
(define-key map "p" 'notmuch-pick-prev-matching-message)
(define-key map "N" 'notmuch-pick-next-message)
(define-key map "P" 'notmuch-pick-prev-message)
- (define-key map "|" 'notmuch-pick-pipe-message)
(define-key map "-" 'notmuch-pick-remove-tag)
(define-key map "+" 'notmuch-pick-add-tag)
(define-key map " " 'notmuch-pick-scroll-or-next)
@@ -586,34 +589,6 @@ message will be \"unarchived\", i.e. the tag changes in
(notmuch-pick-close-message-window)
(notmuch-mua-new-reply (notmuch-pick-get-message-id) prompt-for-sender nil))
-;; Shamelessly stolen from notmuch-show.el: maybe should be unified.
-(defun notmuch-pick-pipe-message (command)
- "Pipe the contents of the current message to the given command.
-
-The given command will be executed with the raw contents of the
-current email message as stdin. Anything printed by the command
-to stdout or stderr will appear in the *notmuch-pipe* buffer.
-
-When invoked with a prefix argument, the command will receive all
-open messages in the current thread (formatted as an mbox) rather
-than only the current message."
- (interactive "sPipe message to command: ")
- (let ((shell-command
- (concat notmuch-command " show --format=raw "
- (shell-quote-argument (notmuch-pick-get-message-id)) " | " command))
- (buf (get-buffer-create (concat "*notmuch-pipe*"))))
- (with-current-buffer buf
- (setq buffer-read-only nil)
- (erase-buffer)
- (let ((exit-code (call-process-shell-command shell-command nil buf)))
- (goto-char (point-max))
- (set-buffer-modified-p nil)
- (setq buffer-read-only t)
- (unless (zerop exit-code)
- (switch-to-buffer-other-window buf)
- (message (format "Command '%s' exited abnormally with code %d"
- shell-command exit-code)))))))
-
(defun notmuch-pick-clean-address (address)
"Try to clean a single email ADDRESS for display. Return
AUTHOR_NAME if present, otherwise return AUTHOR_EMAIL. Return
--
1.7.9.1
next prev parent reply other threads:[~2013-07-05 18:11 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-05 18:11 [PATCH 00/11] contrib: pick: keybindings Mark Walters
2013-07-05 18:11 ` [PATCH 01/11] contrib: pick: override notmuch-show-get-prop Mark Walters
2013-07-05 18:11 ` Mark Walters [this message]
2013-07-05 18:11 ` [PATCH 03/11] contrib: pick: Link in attachment functions straight from notmuch-show Mark Walters
2013-07-05 18:11 ` [PATCH 04/11] contrib: pick: Link in stash map " Mark Walters
2013-07-05 18:11 ` [PATCH 05/11] contrib: pick: add in to-message-window function Mark Walters
2013-07-05 18:11 ` [PATCH 06/11] contrib: pick: add button press helper Mark Walters
2013-07-05 18:11 ` [PATCH 07/11] contrib: pick: pass tab through to the message pane Mark Walters
2013-07-05 18:11 ` [PATCH 08/11] contrib: pick: close window function Mark Walters
2013-07-05 18:11 ` [PATCH 09/11] contrib: pick: make help close the message pane first Mark Walters
2013-07-05 18:11 ` [PATCH 10/11] contrib: pick: add in binding to view raw message Mark Walters
2013-07-05 18:11 ` [PATCH 11/11] contrib: pick: use close-message-pane for reply etc Mark Walters
2013-07-06 8:33 ` [PATCH 00/11] contrib: pick: keybindings Tomi Ollila
2013-07-21 8:36 ` Mark Walters
2013-08-24 9:33 ` David Bremner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1373047878-20822-3-git-send-email-markwalters1009@gmail.com \
--to=markwalters1009@gmail.com \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).