From: Mark Walters <markwalters1009@gmail.com>
To: notmuch@notmuchmail.org
Subject: [PATCH] contrib: pick: use notmuch-start-notmuch
Date: Thu, 4 Jul 2013 08:09:48 +0100 [thread overview]
Message-ID: <1372921788-16042-1-git-send-email-markwalters1009@gmail.com> (raw)
This uses the new notmuch-start-notmuch function which should give
better handling of stderr and errors generally.
---
Hi
This converts pick to Austin's new async error handling code (see
commit 08fde50bf3a4c54f6413aff4052e0d84392463f9). That code separates
stderr from stdout and makes sure that appropriate messages are
displayed to the user.
I think this is simple enough and beneficial enough to go in for 0.16
(so I will tag it 0.16). Of course it only affects notmuch-pick so
is relatively safe.
Best wishes
Mark
contrib/notmuch-pick/notmuch-pick.el | 7 +++----
1 files changed, 3 insertions(+), 4 deletions(-)
diff --git a/contrib/notmuch-pick/notmuch-pick.el b/contrib/notmuch-pick/notmuch-pick.el
index fbd7c0b..7f5f729 100644
--- a/contrib/notmuch-pick/notmuch-pick.el
+++ b/contrib/notmuch-pick/notmuch-pick.el
@@ -817,16 +817,15 @@ Complete list of currently available key bindings:
(if (equal (car (process-lines notmuch-command "count" search-args)) "0")
(setq search-args basic-query))
(if notmuch-pick-asynchronous-parser
- (let ((proc (start-process
- "notmuch-pick" buffer
- notmuch-command "show" "--body=false" "--format=sexp"
+ (let ((proc (notmuch-start-notmuch
+ "notmuch-pick" buffer #'notmuch-pick-process-sentinel
+ "show" "--body=false" "--format=sexp"
message-arg search-args))
;; Use a scratch buffer to accumulate partial output.
;; This buffer will be killed by the sentinel, which
;; should be called no matter how the process dies.
(parse-buf (generate-new-buffer " *notmuch pick parse*")))
(process-put proc 'parse-buf parse-buf)
- (set-process-sentinel proc 'notmuch-pick-process-sentinel)
(set-process-filter proc 'notmuch-pick-process-filter)
(set-process-query-on-exit-flag proc nil))
(progn
--
1.7.9.1
next reply other threads:[~2013-07-04 7:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-04 7:09 Mark Walters [this message]
2013-07-04 7:38 ` [PATCH] contrib: pick: use notmuch-start-notmuch Tomi Ollila
2013-07-04 8:07 ` Mark Walters
2013-07-20 17:31 ` David Bremner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1372921788-16042-1-git-send-email-markwalters1009@gmail.com \
--to=markwalters1009@gmail.com \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).