From: Mark Walters <markwalters1009@gmail.com>
To: notmuch@notmuchmail.org
Subject: [PATCH 0/5] Document notmuch-pick and some bugfixes
Date: Mon, 1 Jul 2013 08:53:58 +0100 [thread overview]
Message-ID: <1372665243-7675-1-git-send-email-markwalters1009@gmail.com> (raw)
This adds some documentation to all the defvars in notmuch-pick and to
the notmuch-pick function itself (as suggested by David in
id:87li5rtvbh.fsf@zancas.localnet. This series replaces
id:1372627117-31188-1-git-send-email-markwalters1009@gmail.com but
does still need to be applied on top of the main series there (because
it documents the pick function as it is after that change).
When documenting the defvars I found some trivial bugs: the most
serious being the wrong variable name being made buffer-local. This is
less serious than it could be as this variable was just used to try
and avoid closing the message pane if the user had loaded a different
buffer into it.
The other "bugs" were defvars for variables which are no longer
used. In one case a moderate amount of effort was made passing this
unused variable around so the patch to remove it is not tiny and thus
its removal is delayed until a followup series.
Finally, when looking at which functions did not have docstrings (some
still need to be added after this series) I found an unused historical
function so remove that too.
Best wishes
Mark
Mark Walters (5):
contrib: pick: add a docstring for the main notmuch-pick function
contrib: pick: add docstrings to all defvars
contrib: pick: bugfix: make the right variable buffer-local
contrib: pick: remove unused variable
contrib: pick: remove unused function
contrib/notmuch-pick/notmuch-pick.el | 71 ++++++++++++++++++++-------------
1 files changed, 43 insertions(+), 28 deletions(-)
--
1.7.9.1
next reply other threads:[~2013-07-01 7:54 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-01 7:53 Mark Walters [this message]
2013-07-01 7:53 ` [PATCH 1/5] contrib: pick: add a docstring for the main notmuch-pick function Mark Walters
2013-07-01 7:54 ` [PATCH 2/5] contrib: pick: add docstrings to all defvars Mark Walters
2013-07-01 7:54 ` [PATCH 3/5] contrib: pick: bugfix: make the right variable buffer-local Mark Walters
2013-07-01 7:54 ` [PATCH 4/5] contrib: pick: remove unused variable Mark Walters
2013-07-01 7:54 ` [PATCH 5/5] contrib: pick: remove unused function Mark Walters
2013-07-04 3:47 ` [PATCH 0/5] Document notmuch-pick and some bugfixes David Bremner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1372665243-7675-1-git-send-email-markwalters1009@gmail.com \
--to=markwalters1009@gmail.com \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).