From: Peter Wang <novalazy@gmail.com>
To: notmuch@notmuchmail.org
Subject: [PATCH v7 02/12] tag-util: do not reset list in parse_tag_command_line
Date: Sun, 23 Jun 2013 14:23:55 +1000 [thread overview]
Message-ID: <1371961445-15182-3-git-send-email-novalazy@gmail.com> (raw)
In-Reply-To: <1371961445-15182-1-git-send-email-novalazy@gmail.com>
The 'insert' command will be better served if parse_tag_command_line
modifies a pre-populated list (of new.tags) instead of clobbering the
list outright. The sole existing caller, notmuch_tag_command, is
unaffected by this change.
---
tag-util.c | 2 --
tag-util.h | 2 ++
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/tag-util.c b/tag-util.c
index 92e08a1..3bde409 100644
--- a/tag-util.c
+++ b/tag-util.c
@@ -165,8 +165,6 @@ parse_tag_command_line (void *ctx, int argc, char **argv,
int i;
- tag_op_list_reset (tag_ops);
-
for (i = 0; i < argc; i++) {
if (strcmp (argv[i], "--") == 0) {
i++;
diff --git a/tag-util.h b/tag-util.h
index 246de85..4628f16 100644
--- a/tag-util.h
+++ b/tag-util.h
@@ -81,6 +81,8 @@ parse_tag_line (void *ctx, char *line,
* Output Parameters:
* ops contains a list of tag operations
* query_str the search terms.
+ *
+ * The ops argument is not cleared.
*/
tag_parse_status_t
--
1.7.12.1
next prev parent reply other threads:[~2013-06-23 4:24 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-23 4:23 [PATCH v7 00/12] insert command Peter Wang
2013-06-23 4:23 ` [PATCH v7 01/12] tag-util: move out 'tag' command-line check Peter Wang
2013-06-23 4:23 ` Peter Wang [this message]
2013-06-23 4:23 ` [PATCH v7 03/12] cli: add insert command Peter Wang
2013-06-23 6:42 ` Mark Walters
2013-06-23 12:19 ` Peter Wang
2013-06-23 12:20 ` [PATCH v7b] " Peter Wang
2013-06-24 19:02 ` Mark Walters
2013-06-23 4:23 ` [PATCH v7 04/12] man: document 'insert' command Peter Wang
2013-06-23 4:23 ` [PATCH v7 05/12] man: reference notmuch-insert.1 Peter Wang
2013-06-23 4:23 ` [PATCH v7 06/12] test: add tests for insert Peter Wang
2013-06-30 14:44 ` David Bremner
2013-06-23 4:24 ` [PATCH v7 07/12] insert: add --folder option Peter Wang
2013-06-23 4:24 ` [PATCH v7 08/12] man: document insert " Peter Wang
2013-06-23 4:24 ` [PATCH v7 09/12] test: test " Peter Wang
2013-07-01 15:29 ` David Bremner
2013-06-23 4:24 ` [PATCH v7 10/12] insert: add --create-folder option Peter Wang
2013-06-23 4:24 ` [PATCH v7 11/12] man: document insert --create-folder Peter Wang
2013-06-23 4:24 ` [PATCH v7 12/12] test: test insert --create-folder option Peter Wang
2013-07-04 3:33 ` David Bremner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1371961445-15182-3-git-send-email-novalazy@gmail.com \
--to=novalazy@gmail.com \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).