From: Peter Wang <novalazy@gmail.com>
To: notmuch@notmuchmail.org
Subject: [PATCH v6 02/12] tag-util: do not reset list in parse_tag_command_line
Date: Sat, 22 Jun 2013 15:46:38 +1000 [thread overview]
Message-ID: <1371880008-18312-3-git-send-email-novalazy@gmail.com> (raw)
In-Reply-To: <1371880008-18312-1-git-send-email-novalazy@gmail.com>
No current callers of parse_tag_command_line require that it clear its
tag list argument. The notmuch 'insert' command will be better served
if the function modifies a pre-populated list (of new.tags) instead of
clobbering it outright.
---
tag-util.c | 2 --
tag-util.h | 2 ++
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/tag-util.c b/tag-util.c
index 92e08a1..3bde409 100644
--- a/tag-util.c
+++ b/tag-util.c
@@ -165,8 +165,6 @@ parse_tag_command_line (void *ctx, int argc, char **argv,
int i;
- tag_op_list_reset (tag_ops);
-
for (i = 0; i < argc; i++) {
if (strcmp (argv[i], "--") == 0) {
i++;
diff --git a/tag-util.h b/tag-util.h
index 246de85..4628f16 100644
--- a/tag-util.h
+++ b/tag-util.h
@@ -81,6 +81,8 @@ parse_tag_line (void *ctx, char *line,
* Output Parameters:
* ops contains a list of tag operations
* query_str the search terms.
+ *
+ * The ops argument is not cleared.
*/
tag_parse_status_t
--
1.7.12.1
next prev parent reply other threads:[~2013-06-22 5:47 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-22 5:46 [PATCH v6 00/12] insert command Peter Wang
2013-06-22 5:46 ` [PATCH v6 01/12] tag-util: move out 'tag' command-line checks Peter Wang
2013-06-22 6:50 ` Mark Walters
2013-06-22 5:46 ` Peter Wang [this message]
2013-06-22 6:52 ` [PATCH v6 02/12] tag-util: do not reset list in parse_tag_command_line Mark Walters
2013-06-22 5:46 ` [PATCH v6 03/12] cli: add insert command Peter Wang
2013-06-22 6:55 ` Mark Walters
2013-06-22 7:48 ` Mark Walters
2013-06-23 3:57 ` Peter Wang
2013-06-22 5:46 ` [PATCH v6 04/12] man: document 'insert' command Peter Wang
2013-06-22 5:46 ` [PATCH v6 05/12] man: reference notmuch-insert.1 Peter Wang
2013-06-22 5:46 ` [PATCH v6 06/12] test: add tests for insert Peter Wang
2013-06-22 5:46 ` [PATCH v6 07/12] insert: add --folder option Peter Wang
2013-06-22 5:46 ` [PATCH v6 08/12] man: document insert " Peter Wang
2013-06-22 5:46 ` [PATCH v6 09/12] test: test " Peter Wang
2013-06-22 5:46 ` [PATCH v6 10/12] insert: add --create-folder option Peter Wang
2013-06-22 5:46 ` [PATCH v6 11/12] man: document insert --create-folder Peter Wang
2013-06-22 5:46 ` [PATCH v6 12/12] test: test insert --create-folder option Peter Wang
2013-06-22 7:55 ` [PATCH v6 00/12] insert command Mark Walters
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1371880008-18312-3-git-send-email-novalazy@gmail.com \
--to=novalazy@gmail.com \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).