* [PATCH] emacs: update search sort order help to match code
@ 2013-06-03 17:56 Jani Nikula
2013-06-10 15:41 ` Tomi Ollila
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Jani Nikula @ 2013-06-03 17:56 UTC (permalink / raw)
To: notmuch
---
emacs/notmuch-lib.el | 7 ++++++-
emacs/notmuch.el | 13 ++-----------
2 files changed, 8 insertions(+), 12 deletions(-)
diff --git a/emacs/notmuch-lib.el b/emacs/notmuch-lib.el
index 28f78e0..c43d5a9 100644
--- a/emacs/notmuch-lib.el
+++ b/emacs/notmuch-lib.el
@@ -68,7 +68,12 @@
:group 'notmuch)
(defcustom notmuch-search-oldest-first t
- "Show the oldest mail first when searching."
+ "Show the oldest mail first when searching.
+
+This variable defines the default sort order for displaying
+search results. Note that any filtered searches created by
+`notmuch-search-filter' retain the search order of the parent
+search."
:type 'boolean
:group 'notmuch-search)
diff --git a/emacs/notmuch.el b/emacs/notmuch.el
index 26ba7e7..cc62088 100644
--- a/emacs/notmuch.el
+++ b/emacs/notmuch.el
@@ -1030,17 +1030,8 @@ depending on the value of `notmuch-poll-script'."
(defun notmuch-search-toggle-order ()
"Toggle the current search order.
-By default, the \"inbox\" view created by `notmuch' is displayed
-in chronological order (oldest thread at the beginning of the
-buffer), while any global searches created by `notmuch-search'
-are displayed in reverse-chronological order (newest thread at
-the beginning of the buffer).
-
-This command toggles the sort order for the current search.
-
-Note that any filtered searches created by
-`notmuch-search-filter' retain the search order of the parent
-search."
+This command toggles the sort order for the current search. The
+default sort order is defined by `notmuch-search-oldest-first'."
(interactive)
(set 'notmuch-search-oldest-first (not notmuch-search-oldest-first))
(notmuch-search-refresh-view))
--
1.7.10.4
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] emacs: update search sort order help to match code
2013-06-03 17:56 [PATCH] emacs: update search sort order help to match code Jani Nikula
@ 2013-06-10 15:41 ` Tomi Ollila
2013-06-10 19:43 ` Mark Walters
2013-06-25 6:07 ` David Bremner
2 siblings, 0 replies; 4+ messages in thread
From: Tomi Ollila @ 2013-06-10 15:41 UTC (permalink / raw)
To: Jani Nikula, notmuch
On Mon, Jun 03 2013, Jani Nikula <jani@nikula.org> wrote:
> ---
LGTM.
Tomi
> emacs/notmuch-lib.el | 7 ++++++-
> emacs/notmuch.el | 13 ++-----------
> 2 files changed, 8 insertions(+), 12 deletions(-)
>
> diff --git a/emacs/notmuch-lib.el b/emacs/notmuch-lib.el
> index 28f78e0..c43d5a9 100644
> --- a/emacs/notmuch-lib.el
> +++ b/emacs/notmuch-lib.el
> @@ -68,7 +68,12 @@
> :group 'notmuch)
>
> (defcustom notmuch-search-oldest-first t
> - "Show the oldest mail first when searching."
> + "Show the oldest mail first when searching.
> +
> +This variable defines the default sort order for displaying
> +search results. Note that any filtered searches created by
> +`notmuch-search-filter' retain the search order of the parent
> +search."
> :type 'boolean
> :group 'notmuch-search)
>
> diff --git a/emacs/notmuch.el b/emacs/notmuch.el
> index 26ba7e7..cc62088 100644
> --- a/emacs/notmuch.el
> +++ b/emacs/notmuch.el
> @@ -1030,17 +1030,8 @@ depending on the value of `notmuch-poll-script'."
> (defun notmuch-search-toggle-order ()
> "Toggle the current search order.
>
> -By default, the \"inbox\" view created by `notmuch' is displayed
> -in chronological order (oldest thread at the beginning of the
> -buffer), while any global searches created by `notmuch-search'
> -are displayed in reverse-chronological order (newest thread at
> -the beginning of the buffer).
> -
> -This command toggles the sort order for the current search.
> -
> -Note that any filtered searches created by
> -`notmuch-search-filter' retain the search order of the parent
> -search."
> +This command toggles the sort order for the current search. The
> +default sort order is defined by `notmuch-search-oldest-first'."
> (interactive)
> (set 'notmuch-search-oldest-first (not notmuch-search-oldest-first))
> (notmuch-search-refresh-view))
> --
> 1.7.10.4
>
> _______________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org
> http://notmuchmail.org/mailman/listinfo/notmuch
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] emacs: update search sort order help to match code
2013-06-03 17:56 [PATCH] emacs: update search sort order help to match code Jani Nikula
2013-06-10 15:41 ` Tomi Ollila
@ 2013-06-10 19:43 ` Mark Walters
2013-06-25 6:07 ` David Bremner
2 siblings, 0 replies; 4+ messages in thread
From: Mark Walters @ 2013-06-10 19:43 UTC (permalink / raw)
To: Jani Nikula, notmuch
LGTM +1
Mark
On Mon, 03 Jun 2013, Jani Nikula <jani@nikula.org> wrote:
> ---
> emacs/notmuch-lib.el | 7 ++++++-
> emacs/notmuch.el | 13 ++-----------
> 2 files changed, 8 insertions(+), 12 deletions(-)
>
> diff --git a/emacs/notmuch-lib.el b/emacs/notmuch-lib.el
> index 28f78e0..c43d5a9 100644
> --- a/emacs/notmuch-lib.el
> +++ b/emacs/notmuch-lib.el
> @@ -68,7 +68,12 @@
> :group 'notmuch)
>
> (defcustom notmuch-search-oldest-first t
> - "Show the oldest mail first when searching."
> + "Show the oldest mail first when searching.
> +
> +This variable defines the default sort order for displaying
> +search results. Note that any filtered searches created by
> +`notmuch-search-filter' retain the search order of the parent
> +search."
> :type 'boolean
> :group 'notmuch-search)
>
> diff --git a/emacs/notmuch.el b/emacs/notmuch.el
> index 26ba7e7..cc62088 100644
> --- a/emacs/notmuch.el
> +++ b/emacs/notmuch.el
> @@ -1030,17 +1030,8 @@ depending on the value of `notmuch-poll-script'."
> (defun notmuch-search-toggle-order ()
> "Toggle the current search order.
>
> -By default, the \"inbox\" view created by `notmuch' is displayed
> -in chronological order (oldest thread at the beginning of the
> -buffer), while any global searches created by `notmuch-search'
> -are displayed in reverse-chronological order (newest thread at
> -the beginning of the buffer).
> -
> -This command toggles the sort order for the current search.
> -
> -Note that any filtered searches created by
> -`notmuch-search-filter' retain the search order of the parent
> -search."
> +This command toggles the sort order for the current search. The
> +default sort order is defined by `notmuch-search-oldest-first'."
> (interactive)
> (set 'notmuch-search-oldest-first (not notmuch-search-oldest-first))
> (notmuch-search-refresh-view))
> --
> 1.7.10.4
>
> _______________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org
> http://notmuchmail.org/mailman/listinfo/notmuch
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] emacs: update search sort order help to match code
2013-06-03 17:56 [PATCH] emacs: update search sort order help to match code Jani Nikula
2013-06-10 15:41 ` Tomi Ollila
2013-06-10 19:43 ` Mark Walters
@ 2013-06-25 6:07 ` David Bremner
2 siblings, 0 replies; 4+ messages in thread
From: David Bremner @ 2013-06-25 6:07 UTC (permalink / raw)
To: Jani Nikula, notmuch
Jani Nikula <jani@nikula.org> writes:
> ---
> emacs/notmuch-lib.el | 7 ++++++-
> emacs/notmuch.el | 13 ++-----------
> 2 files changed, 8 insertions(+), 12 deletions(-)
>
pushed, although maybe the commit message was a bit terse.
d
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2013-06-25 6:08 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-06-03 17:56 [PATCH] emacs: update search sort order help to match code Jani Nikula
2013-06-10 15:41 ` Tomi Ollila
2013-06-10 19:43 ` Mark Walters
2013-06-25 6:07 ` David Bremner
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).