* [RFC PATCH] emacs: Remove v command
@ 2013-06-03 15:54 Austin Clements
2013-06-03 16:28 ` Mark Walters
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Austin Clements @ 2013-06-03 15:54 UTC (permalink / raw)
To: notmuch
This removes the v command, since we now have much nicer part commands,
and deprecates the underlying notmuch-show-view-all-mime-parts. This
also means that people who try using the old unprefixed 'v' command on
a part button will no longer be greeted by ALL of their parts popping
up.
---
emacs/notmuch-show.el | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el
index 5771950..bae3171 100644
--- a/emacs/notmuch-show.el
+++ b/emacs/notmuch-show.el
@@ -213,6 +213,9 @@ For example, if you wanted to remove an \"unread\" tag and add a
"Enable Visual Line mode."
(visual-line-mode t))
+;; DEPRECATED in Notmuch 0.16 since we now have convenient part
+;; commands. We'll keep the command around for a version or two in
+;; case people want to bind it themselves.
(defun notmuch-show-view-all-mime-parts ()
"Use external viewers to view all attachments from the current message."
(interactive)
@@ -1216,7 +1219,6 @@ reset based on the original query."
(define-key map "|" 'notmuch-show-pipe-message)
(define-key map "w" 'notmuch-show-save-attachments)
(define-key map "V" 'notmuch-show-view-raw-message)
- (define-key map "v" 'notmuch-show-view-all-mime-parts)
(define-key map "c" 'notmuch-show-stash-map)
(define-key map "=" 'notmuch-show-refresh-view)
(define-key map "h" 'notmuch-show-toggle-visibility-headers)
--
1.7.10.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [RFC PATCH] emacs: Remove v command
2013-06-03 15:54 [RFC PATCH] emacs: Remove v command Austin Clements
@ 2013-06-03 16:28 ` Mark Walters
2013-06-03 17:25 ` Tomi Ollila
2013-06-25 6:08 ` David Bremner
2 siblings, 0 replies; 4+ messages in thread
From: Mark Walters @ 2013-06-03 16:28 UTC (permalink / raw)
To: Austin Clements, notmuch
I like the change. +1 from me.
Mark
Austin Clements <amdragon@MIT.EDU> writes:
> This removes the v command, since we now have much nicer part commands,
> and deprecates the underlying notmuch-show-view-all-mime-parts. This
> also means that people who try using the old unprefixed 'v' command on
> a part button will no longer be greeted by ALL of their parts popping
> up.
> ---
> emacs/notmuch-show.el | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el
> index 5771950..bae3171 100644
> --- a/emacs/notmuch-show.el
> +++ b/emacs/notmuch-show.el
> @@ -213,6 +213,9 @@ For example, if you wanted to remove an \"unread\" tag and add a
> "Enable Visual Line mode."
> (visual-line-mode t))
>
> +;; DEPRECATED in Notmuch 0.16 since we now have convenient part
> +;; commands. We'll keep the command around for a version or two in
> +;; case people want to bind it themselves.
> (defun notmuch-show-view-all-mime-parts ()
> "Use external viewers to view all attachments from the current message."
> (interactive)
> @@ -1216,7 +1219,6 @@ reset based on the original query."
> (define-key map "|" 'notmuch-show-pipe-message)
> (define-key map "w" 'notmuch-show-save-attachments)
> (define-key map "V" 'notmuch-show-view-raw-message)
> - (define-key map "v" 'notmuch-show-view-all-mime-parts)
> (define-key map "c" 'notmuch-show-stash-map)
> (define-key map "=" 'notmuch-show-refresh-view)
> (define-key map "h" 'notmuch-show-toggle-visibility-headers)
> --
> 1.7.10.4
>
> _______________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org
> http://notmuchmail.org/mailman/listinfo/notmuch
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [RFC PATCH] emacs: Remove v command
2013-06-03 15:54 [RFC PATCH] emacs: Remove v command Austin Clements
2013-06-03 16:28 ` Mark Walters
@ 2013-06-03 17:25 ` Tomi Ollila
2013-06-25 6:08 ` David Bremner
2 siblings, 0 replies; 4+ messages in thread
From: Tomi Ollila @ 2013-06-03 17:25 UTC (permalink / raw)
To: Austin Clements, notmuch
On Mon, Jun 03 2013, Austin Clements <amdragon@MIT.EDU> wrote:
> This removes the v command, since we now have much nicer part commands,
> and deprecates the underlying notmuch-show-view-all-mime-parts. This
> also means that people who try using the old unprefixed 'v' command on
> a part button will no longer be greeted by ALL of their parts popping
> up.
> ---
+1
Tomi
> emacs/notmuch-show.el | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el
> index 5771950..bae3171 100644
> --- a/emacs/notmuch-show.el
> +++ b/emacs/notmuch-show.el
> @@ -213,6 +213,9 @@ For example, if you wanted to remove an \"unread\" tag and add a
> "Enable Visual Line mode."
> (visual-line-mode t))
>
> +;; DEPRECATED in Notmuch 0.16 since we now have convenient part
> +;; commands. We'll keep the command around for a version or two in
> +;; case people want to bind it themselves.
> (defun notmuch-show-view-all-mime-parts ()
> "Use external viewers to view all attachments from the current message."
> (interactive)
> @@ -1216,7 +1219,6 @@ reset based on the original query."
> (define-key map "|" 'notmuch-show-pipe-message)
> (define-key map "w" 'notmuch-show-save-attachments)
> (define-key map "V" 'notmuch-show-view-raw-message)
> - (define-key map "v" 'notmuch-show-view-all-mime-parts)
> (define-key map "c" 'notmuch-show-stash-map)
> (define-key map "=" 'notmuch-show-refresh-view)
> (define-key map "h" 'notmuch-show-toggle-visibility-headers)
> --
> 1.7.10.4
>
> _______________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org
> http://notmuchmail.org/mailman/listinfo/notmuch
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [RFC PATCH] emacs: Remove v command
2013-06-03 15:54 [RFC PATCH] emacs: Remove v command Austin Clements
2013-06-03 16:28 ` Mark Walters
2013-06-03 17:25 ` Tomi Ollila
@ 2013-06-25 6:08 ` David Bremner
2 siblings, 0 replies; 4+ messages in thread
From: David Bremner @ 2013-06-25 6:08 UTC (permalink / raw)
To: Austin Clements, notmuch
Austin Clements <amdragon@MIT.EDU> writes:
> This removes the v command, since we now have much nicer part commands,
> and deprecates the underlying notmuch-show-view-all-mime-parts. This
> also means that people who try using the old unprefixed 'v' command on
> a part button will no longer be greeted by ALL of their parts popping
> up.
pushed.
Let the complaints begin,
d
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2013-06-25 6:08 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-06-03 15:54 [RFC PATCH] emacs: Remove v command Austin Clements
2013-06-03 16:28 ` Mark Walters
2013-06-03 17:25 ` Tomi Ollila
2013-06-25 6:08 ` David Bremner
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).