* [PATCH] contrib: pick: use the sexp parser
@ 2013-06-01 19:04 Mark Walters
2013-06-01 20:49 ` Tomi Ollila
2013-06-02 11:11 ` David Bremner
0 siblings, 2 replies; 4+ messages in thread
From: Mark Walters @ 2013-06-01 19:04 UTC (permalink / raw)
To: notmuch
This just converts notmuch-pick to use the sexp parser.
---
contrib/notmuch-pick/notmuch-pick.el | 5 ++---
1 files changed, 2 insertions(+), 3 deletions(-)
diff --git a/contrib/notmuch-pick/notmuch-pick.el b/contrib/notmuch-pick/notmuch-pick.el
index 128fabf..33905d6 100644
--- a/contrib/notmuch-pick/notmuch-pick.el
+++ b/contrib/notmuch-pick/notmuch-pick.el
@@ -773,8 +773,7 @@ Complete list of currently available key bindings:
(save-excursion
(goto-char (point-max))
(insert string))
- (notmuch-json-parse-partial-list 'notmuch-pick-insert-forest-thread
- 'notmuch-pick-show-error
+ (notmuch-sexp-parse-partial-list 'notmuch-pick-insert-forest-thread
results-buf)))))
(defun notmuch-pick-worker (basic-query &optional query-context target buffer)
@@ -796,7 +795,7 @@ Complete list of currently available key bindings:
(if notmuch-pick-asynchronous-parser
(let ((proc (start-process
"notmuch-pick" buffer
- notmuch-command "show" "--body=false" "--format=json"
+ notmuch-command "show" "--body=false" "--format=sexp"
message-arg search-args))
;; Use a scratch buffer to accumulate partial output.
;; This buffer will be killed by the sentinel, which
--
1.7.9.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] contrib: pick: use the sexp parser
2013-06-01 19:04 [PATCH] contrib: pick: use the sexp parser Mark Walters
@ 2013-06-01 20:49 ` Tomi Ollila
2013-06-02 12:01 ` Mark Walters
2013-06-02 11:11 ` David Bremner
1 sibling, 1 reply; 4+ messages in thread
From: Tomi Ollila @ 2013-06-01 20:49 UTC (permalink / raw)
To: Mark Walters, notmuch
On Sat, Jun 01 2013, Mark Walters <markwalters1009@gmail.com> wrote:
> This just converts notmuch-pick to use the sexp parser.
> ---
These trivial changes look good -- is sexp already supported in show ?
Tomi
>
> contrib/notmuch-pick/notmuch-pick.el | 5 ++---
> 1 files changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/contrib/notmuch-pick/notmuch-pick.el b/contrib/notmuch-pick/notmuch-pick.el
> index 128fabf..33905d6 100644
> --- a/contrib/notmuch-pick/notmuch-pick.el
> +++ b/contrib/notmuch-pick/notmuch-pick.el
> @@ -773,8 +773,7 @@ Complete list of currently available key bindings:
> (save-excursion
> (goto-char (point-max))
> (insert string))
> - (notmuch-json-parse-partial-list 'notmuch-pick-insert-forest-thread
> - 'notmuch-pick-show-error
> + (notmuch-sexp-parse-partial-list 'notmuch-pick-insert-forest-thread
> results-buf)))))
>
> (defun notmuch-pick-worker (basic-query &optional query-context target buffer)
> @@ -796,7 +795,7 @@ Complete list of currently available key bindings:
> (if notmuch-pick-asynchronous-parser
> (let ((proc (start-process
> "notmuch-pick" buffer
> - notmuch-command "show" "--body=false" "--format=json"
> + notmuch-command "show" "--body=false" "--format=sexp"
> message-arg search-args))
> ;; Use a scratch buffer to accumulate partial output.
> ;; This buffer will be killed by the sentinel, which
> --
> 1.7.9.1
>
> _______________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org
> http://notmuchmail.org/mailman/listinfo/notmuch
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] contrib: pick: use the sexp parser
2013-06-01 19:04 [PATCH] contrib: pick: use the sexp parser Mark Walters
2013-06-01 20:49 ` Tomi Ollila
@ 2013-06-02 11:11 ` David Bremner
1 sibling, 0 replies; 4+ messages in thread
From: David Bremner @ 2013-06-02 11:11 UTC (permalink / raw)
To: Mark Walters, notmuch
Mark Walters <markwalters1009@gmail.com> writes:
> This just converts notmuch-pick to use the sexp parser.
> ---
Pushed.
d
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] contrib: pick: use the sexp parser
2013-06-01 20:49 ` Tomi Ollila
@ 2013-06-02 12:01 ` Mark Walters
0 siblings, 0 replies; 4+ messages in thread
From: Mark Walters @ 2013-06-02 12:01 UTC (permalink / raw)
To: Tomi Ollila, notmuch
Tomi Ollila <tomi.ollila@iki.fi> writes:
> These trivial changes look good -- is sexp already supported in show ?
At the moment sexp is not supported in show (despite that using
synchronous command so it is much easier). I posted a (not good) at
id:1354975891-24663-1-git-send-email-markwalters1009@gmail.com and in
Austin's reply he suggested a much better way of doing is. But I never posted a
corrected version (perhaps I was waiting for the error handling stuff to
clear?).
Best wishes
Mark
>
> Tomi
>
>>
>> contrib/notmuch-pick/notmuch-pick.el | 5 ++---
>> 1 files changed, 2 insertions(+), 3 deletions(-)
>>
>> diff --git a/contrib/notmuch-pick/notmuch-pick.el b/contrib/notmuch-pick/notmuch-pick.el
>> index 128fabf..33905d6 100644
>> --- a/contrib/notmuch-pick/notmuch-pick.el
>> +++ b/contrib/notmuch-pick/notmuch-pick.el
>> @@ -773,8 +773,7 @@ Complete list of currently available key bindings:
>> (save-excursion
>> (goto-char (point-max))
>> (insert string))
>> - (notmuch-json-parse-partial-list 'notmuch-pick-insert-forest-thread
>> - 'notmuch-pick-show-error
>> + (notmuch-sexp-parse-partial-list 'notmuch-pick-insert-forest-thread
>> results-buf)))))
>>
>> (defun notmuch-pick-worker (basic-query &optional query-context target buffer)
>> @@ -796,7 +795,7 @@ Complete list of currently available key bindings:
>> (if notmuch-pick-asynchronous-parser
>> (let ((proc (start-process
>> "notmuch-pick" buffer
>> - notmuch-command "show" "--body=false" "--format=json"
>> + notmuch-command "show" "--body=false" "--format=sexp"
>> message-arg search-args))
>> ;; Use a scratch buffer to accumulate partial output.
>> ;; This buffer will be killed by the sentinel, which
>> --
>> 1.7.9.1
>>
>> _______________________________________________
>> notmuch mailing list
>> notmuch@notmuchmail.org
>> http://notmuchmail.org/mailman/listinfo/notmuch
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2013-06-02 12:01 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-06-01 19:04 [PATCH] contrib: pick: use the sexp parser Mark Walters
2013-06-01 20:49 ` Tomi Ollila
2013-06-02 12:01 ` Mark Walters
2013-06-02 11:11 ` David Bremner
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).