From: Mark Walters <markwalters1009@gmail.com>
To: notmuch@notmuchmail.org
Subject: [PATCH 0/2] Contrib: Pick: Remove horrible hack
Date: Sun, 26 May 2013 07:50:06 +0100 [thread overview]
Message-ID: <1369551008-30697-1-git-send-email-markwalters1009@gmail.com> (raw)
Pick used to have one horrible hack: if the user asked it to open the
first matching message it had to check whether that had arrived (as
the search is asynchronous) and if not wait and try again. Now the
opening of the first matching message is called via the pick process
filter this hack can be removed.
This did reveal the followibg small bug. Pick shows the subject line
in the output but if it is the same as the previous line (ignoring re:
etc) it shows ... If a single message is refreshed (eg for a tag
update) this was got wrong. The change above triggered this and made
the test fail as the unread tag was removed from the first matching
message when it was displayed.
Patch 2/2 fixes this by storing the previous subject with the search result.
Best wishes
Mark
Mark Walters (2):
contrib: pick: remove hack notmuch-pick-show-match-message-with-wait
contrib: pick: fix refresh result
contrib/notmuch-pick/notmuch-pick.el | 60 ++++++++++++++++-----------------
1 files changed, 29 insertions(+), 31 deletions(-)
--
1.7.9.1
next reply other threads:[~2013-05-26 6:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-26 6:50 Mark Walters [this message]
2013-05-26 6:50 ` [PATCH 1/2] contrib: pick: remove hack notmuch-pick-show-match-message-with-wait Mark Walters
2013-05-26 6:50 ` [PATCH 2/2] contrib: pick: fix refresh result Mark Walters
2013-06-30 8:29 ` [PATCH 0/2] Contrib: Pick: Remove horrible hack Mark Walters
2013-06-30 8:46 ` Mark Walters
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1369551008-30697-1-git-send-email-markwalters1009@gmail.com \
--to=markwalters1009@gmail.com \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).