From: Tomi Ollila <tomi.ollila@iki.fi>
To: notmuch@notmuchmail.org
Cc: tomi.ollila@iki.fi
Subject: [RFC PATCH 1/1] add --stderr option
Date: Tue, 21 May 2013 21:42:30 +0300 [thread overview]
Message-ID: <1369161750-12342-1-git-send-email-tomi.ollila@iki.fi> (raw)
---
Note quickly written untested code (but compiles!), just to show an idea...
This implements (i hope) curl(1) --stderr option in notmuch(1):
--stderr <file>
Redirect all writes to stderr to the specified file instead. If
the file name is a plain '-', it is instead written to stdout.
This would be useful in emacs interface.
Please comment; I'll do help and manual page changes (and NEWS) if
this is good idea :D
Tomi
notmuch.c | 20 ++++++++++++++++++++
1 file changed, 20 insertions(+)
diff --git a/notmuch.c b/notmuch.c
index f51a84f..3b8bd5d 100644
--- a/notmuch.c
+++ b/notmuch.c
@@ -21,6 +21,7 @@
*/
#include "notmuch-client.h"
+#include <fcntl.h>
typedef int (*command_function_t) (notmuch_config_t *config, int argc, char *argv[]);
@@ -259,6 +260,7 @@ main (int argc, char *argv[])
const char *command_name = NULL;
command_t *command;
char *config_file_name = NULL;
+ char *stderr_file = NULL;
notmuch_config_t *config;
notmuch_bool_t print_help=FALSE, print_version=FALSE;
int opt_index;
@@ -268,6 +270,7 @@ main (int argc, char *argv[])
{ NOTMUCH_OPT_BOOLEAN, &print_help, "help", 'h', 0 },
{ NOTMUCH_OPT_BOOLEAN, &print_version, "version", 'v', 0 },
{ NOTMUCH_OPT_STRING, &config_file_name, "config", 'c', 0 },
+ { NOTMUCH_OPT_STRING, &stderr_file, "stderr", 'c', 0 },
{ 0, 0, 0, 0, 0 }
};
@@ -295,6 +298,23 @@ main (int argc, char *argv[])
return 0;
}
+ if (stderr_file) {
+ if (strcmp (stderr_file, "-") == 0)
+ dup2 (STDOUT_FILENO, STDERR_FILENO);
+ else {
+ int fd = open (stderr_file, O_WRONLY|O_CREAT|O_APPEND, 0644);
+ if (fd < 0) {
+ fprintf (stderr, "Error: Cannot redirect stderr to '%s': %s\n",
+ stderr_file, strerror(errno));
+ return 1;
+ }
+ if (fd != STDERR_FILENO) {
+ dup2 (fd, STDERR_FILENO);
+ close (fd);
+ }
+ }
+ }
+
if (opt_index < argc)
command_name = argv[opt_index];
--
1.8.1.4
next reply other threads:[~2013-05-21 18:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-21 18:42 Tomi Ollila [this message]
2013-05-21 19:21 ` [RFC PATCH 1/1] add --stderr option Mark Walters
2013-05-21 19:55 ` Justus Winter
2013-05-22 7:50 ` Tomi Ollila
2013-05-22 11:15 ` Justus Winter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1369161750-12342-1-git-send-email-tomi.ollila@iki.fi \
--to=tomi.ollila@iki.fi \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).