Re: Bug with commit 2e96464f9705be4ec772280cad71a6c9d5831e6f

[racin@free.fr]

[-- Attachment #1: Type: text/plain, Size: 1045 bytes --]

Works with the following patch (replace a DT_UKNOWN with DT_UNKNOWN, else it fails to compile)

Matthieu


----- Mail Original -----
De: "Carl Worth" <cworth@cworth.org>
À: racin@free.fr, "Ali Polatel" <alip@exherbo.org>
Cc: notmuch@notmuchmail.org
Envoyé: Samedi 23 Janvier 2010 07h06:12 GMT +01:00 Amsterdam / Berlin / Berne / Rome / Stockholm / Vienne
Objet: Re: [notmuch] Bug with commit 2e96464f9705be4ec772280cad71a6c9d5831e6f

On Sat, 16 Jan 2010 02:42:39 +0100 (CET), racin@free.fr wrote:
> I still confirm the bug.
> 
> The problem is due to relying on non-standardized fields of directory entries (i.e. d_type), which don't behave the
> same on reiserfs than on ext2 (I use reiserfs). 
> 
> The following ugly patch "solves" my problem.

I just pushed a cleaner version of this patch from a later post. I hope
it helps and that you can have fun with notmuch!

-Carl

PS. Micah and Martin, Stacy says "you're welcome" for this and any
further notmuch work that happens to get done during this vacation. :-)

[-- Attachment #2: patch --]
[-- Type: application/octet-stream, Size: 362 bytes --]

diff --git a/notmuch-new.c b/notmuch-new.c
index 124d38d..f25c71f 100644
--- a/notmuch-new.c
+++ b/notmuch-new.c
@@ -282,7 +282,7 @@ add_files_recursive (notmuch_database_t *notmuch,
 	 * recursion). */
 	if (entry->d_type != DT_DIR &&
 	    entry->d_type != DT_LNK &&
-	    entry->d_type != DT_UKNOWN)
+	    entry->d_type != DT_UNKNOWN)
 	{
 	    continue;
 	}