unofficial mirror of notmuch@notmuchmail.org
 help / color / mirror / code / Atom feed
From: "Kirill A. Shutemov" <kirill@shutemov.name>
To: Felipe Contreras <felipe.contreras@gmail.com>
Cc: notmuch@notmuchmail.org
Subject: [PATCH 5/5] Drop harmful reply buffer preparation
Date: Mon, 28 Jan 2013 17:52:20 +0200	[thread overview]
Message-ID: <1359388340-27136-6-git-send-email-kirill@shutemov.name> (raw)
In-Reply-To: <1359388340-27136-1-git-send-email-kirill@shutemov.name>

From: "Kirill A. Shutemov" <kirill@shutemov.name>

Inserting empty lines at the end of reply buffer and switching to insert
mode are not what user want on reply. It's only annoying if you try to
comment on patch.

If a user really wants this kind of preparation it should be implemented
as an user-specific hook.

Signed-off-by: Kirill A. Shutemov <kirill@shutemov.name>
---
 notmuch-ruby.vim |    4 ----
 1 file changed, 4 deletions(-)

diff --git a/notmuch-ruby.vim b/notmuch-ruby.vim
index cda5df4..44d127f 100644
--- a/notmuch-ruby.vim
+++ b/notmuch-ruby.vim
@@ -144,7 +144,6 @@ ruby << EOF
 EOF
 	call s:set_map(g:notmuch_rb_compose_maps)
 	autocmd BufUnload <buffer> call s:compose_unload()
-	startinsert!
 endfunction
 
 function! s:show_info()
@@ -511,9 +510,6 @@ ruby << EOF
 			part.convert.each_line do |l|
 				body_lines << "> %s" % l.chomp
 			end
-			body_lines << ""
-			body_lines << ""
-			body_lines << ""
 
 			reply.body = body_lines.join("\n")
 
-- 
1.7.10.4

  parent reply	other threads:[~2013-01-28 15:57 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-28 15:52 [PATCH 0/5] Random patches for notmuch-vim-ruby Kirill A. Shutemov
2013-01-28 15:52 ` [PATCH 1/5] open_reply: fallback to use addr.local if addr.name is nil Kirill A. Shutemov
2013-04-02 19:31   ` Felipe Contreras
2013-01-28 15:52 ` [PATCH 2/5] rename g:notmuch_sendmail -> g:notmuch_rb_sendmail Kirill A. Shutemov
2013-04-02 19:21   ` Felipe Contreras
2013-01-28 15:52 ` [PATCH 3/5] /usr/sbin/sendmail as a default g:notmuch_rb_sendmail Kirill A. Shutemov
2013-04-02 19:33   ` Felipe Contreras
2013-01-28 15:52 ` [PATCH 4/5] Introduce g:notmuch_rb_folders_count_threads Kirill A. Shutemov
2013-04-02 19:39   ` Felipe Contreras
2013-01-28 15:52 ` Kirill A. Shutemov [this message]
2013-04-02 19:46   ` [PATCH 5/5] Drop harmful reply buffer preparation Felipe Contreras
2013-01-28 18:09 ` [PATCH 0/5] Random patches for notmuch-vim-ruby David Bremner
2013-04-02 19:52 ` Felipe Contreras

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://notmuchmail.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1359388340-27136-6-git-send-email-kirill@shutemov.name \
    --to=kirill@shutemov.name \
    --cc=felipe.contreras@gmail.com \
    --cc=notmuch@notmuchmail.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://yhetil.org/notmuch.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).