[PATCH 1/1] devel/release-checks.sh: version string problem does not halt execution

[PATCH 1/1] devel/release-checks.sh: version string problem does not halt execution

[Tomi Ollila]

Version string has strict format requirements in release-check.sh:
only numbers and periods (in sane order) are accepted.
Mismatch there used to halt further execution.
In this case, checking versions like '*~rc1' for (more) problems
was not possible.
This 'fatal error' is now changed buffered error message like in
following tests, and is displayed at the end of execution.
---
 devel/release-checks.sh | 9 ++++-----
 1 file changed, 4 insertions(+), 5 deletions(-)

diff --git a/devel/release-checks.sh b/devel/release-checks.sh
index e1d19f2..d2bbc6a 100755
--- a/devel/release-checks.sh
+++ b/devel/release-checks.sh
@@ -53,12 +53,13 @@ fi < ./version
 
 readonly VERSION
 
+# In the rest of this file, tests collect list of errors to be fixed
+
 verfail ()
 {
 	echo No.
-	echo "$@"
-	echo "Please follow the instructions in RELEASING to choose a version"
-	exit 1
+	append_emsg "$@"
+	append_emsg "  Please follow the instructions in RELEASING to choose a version"
 }
 
 echo -n "Checking that '$VERSION' is good with digits and periods... "
@@ -73,8 +74,6 @@ case $VERSION in
 esac
 
 
-# In the rest of this file, tests collect list of errors to be fixed
-
 echo -n "Checking that this is Debian package for notmuch... "
 read deb_notmuch deb_version rest < debian/changelog
 if [ "$deb_notmuch" = 'notmuch' ]
-- 
1.8.0.2

Re: [PATCH 1/1] devel/release-checks.sh: version string problem does not halt execution

[David Bremner]

Tomi Ollila <tomi.ollila@iki.fi> writes:

> Version string has strict format requirements in release-check.sh:
> only numbers and periods (in sane order) are accepted.
> Mismatch there used to halt further execution.
> In this case, checking versions like '*~rc1' for (more) problems
> was not possible.
> This 'fatal error' is now changed buffered error message like in
> following tests, and is displayed at the end of execution.

pushed. That's probably good enough, given the small userbase of this
script.

d