From: david@tethera.net
To: notmuch@notmuchmail.org
Cc: David Bremner <bremner@debian.org>
Subject: [PATCH 1/3] CLI: add talloc leak report, controlled by an environment variable.
Date: Sun, 16 Dec 2012 23:24:05 -0400 [thread overview]
Message-ID: <1355714648-23144-2-git-send-email-david@tethera.net> (raw)
In-Reply-To: <1355714648-23144-1-git-send-email-david@tethera.net>
From: David Bremner <bremner@debian.org>
The argument handling in notmuch.c seems due for an overhaul, but
until then use an environment variable to specify a location to write
the talloc leak report to. This is only enabled for the (interesting)
case where some notmuch subcommand is invoked.
---
notmuch.c | 16 ++++++++++++++--
1 file changed, 14 insertions(+), 2 deletions(-)
diff --git a/notmuch.c b/notmuch.c
index 9516dfb..fb49c5a 100644
--- a/notmuch.c
+++ b/notmuch.c
@@ -322,8 +322,20 @@ main (int argc, char *argv[])
for (i = 0; i < ARRAY_SIZE (commands); i++) {
command = &commands[i];
- if (strcmp (argv[1], command->name) == 0)
- return (command->function) (local, argc - 1, &argv[1]);
+ if (strcmp (argv[1], command->name) == 0) {
+ int ret;
+ char *talloc_report;
+
+ ret = (command->function) (local, argc - 1, &argv[1]);
+
+ talloc_report=getenv ("NOTMUCH_TALLOC_REPORT");
+ if (talloc_report && strcmp(talloc_report, "") != 0) {
+ FILE *report = fopen (talloc_report, "w");
+ talloc_report_full (NULL, report);
+ }
+
+ return ret;
+ }
}
fprintf (stderr, "Error: Unknown command '%s' (see \"notmuch help\")\n",
--
1.7.10.4
next prev parent reply other threads:[~2012-12-17 3:24 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-17 3:24 talloc leak debugging david
2012-12-17 3:24 ` david [this message]
2012-12-20 15:40 ` [PATCH 1/3] CLI: add talloc leak report, controlled by an environment variable Tomi Ollila
2012-12-20 16:58 ` David Bremner
2012-12-21 1:55 ` Austin Clements
2012-12-17 3:24 ` [PATCH 2/3] util: add xtalloc.[ch] david
2012-12-20 15:42 ` Tomi Ollila
2012-12-21 2:03 ` Austin Clements
2012-12-17 3:24 ` [PATCH 3/3] notmuch-restore: use xtalloc version of strndup david
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1355714648-23144-2-git-send-email-david@tethera.net \
--to=david@tethera.net \
--cc=bremner@debian.org \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).