From: Mark Walters <markwalters1009@gmail.com>
To: notmuch@notmuchmail.org
Subject: [PATCH v2 1/5] emacs: show: modify insert-part-header to save the button text
Date: Thu, 13 Dec 2012 09:12:00 +0000 [thread overview]
Message-ID: <1355389924-3718-2-git-send-email-markwalters1009@gmail.com> (raw)
In-Reply-To: <1355389924-3718-1-git-send-email-markwalters1009@gmail.com>
This just make notmuch-show-insert-part-header save the basic button
text for parts as an attribute. This makes it simpler for the button
action (added in a later patch) to reword the label as appropriate (eg
append "(not shown)" or not as appropriate).
---
emacs/notmuch-show.el | 18 +++++++++---------
1 files changed, 9 insertions(+), 9 deletions(-)
diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el
index d7fa10e..06f7ca5 100644
--- a/emacs/notmuch-show.el
+++ b/emacs/notmuch-show.el
@@ -483,17 +483,17 @@ message at DEPTH in the current thread."
(fset 'notmuch-show-part-button-map notmuch-show-part-button-map)
(defun notmuch-show-insert-part-header (nth content-type declared-type &optional name comment)
- (let ((button))
+ (let ((button)
+ (base-label (concat (when name (concat name ": "))
+ declared-type
+ (unless (string-equal declared-type content-type)
+ (concat " (as " content-type ")"))
+ comment)))
+
(setq button
(insert-button
- (concat "[ "
- (if name (concat name ": ") "")
- declared-type
- (if (not (string-equal declared-type content-type))
- (concat " (as " content-type ")")
- "")
- (or comment "")
- " ]")
+ (concat "[ " base-label " ]")
+ :base-label base-label
:type 'notmuch-show-part-button-type
:notmuch-part nth
:notmuch-filename name
--
1.7.9.1
next prev parent reply other threads:[~2012-12-13 9:12 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-13 9:11 [PATCH v2 0/5] Use invisibility to toggle display of all parts including multipart Mark Walters
2012-12-13 9:12 ` Mark Walters [this message]
2012-12-13 9:12 ` [PATCH v2 2/5] emacs: show: add overlays for each part Mark Walters
2012-12-15 5:39 ` Austin Clements
2012-12-13 9:12 ` [PATCH v2 3/5] emacs: show: add invisibility button action Mark Walters
2012-12-15 5:45 ` Austin Clements
2012-12-13 9:12 ` [PATCH v2 4/5] emacs: wash: fix fake-diff part to include msg parameter Mark Walters
2012-12-13 9:12 ` [PATCH v2 5/5] emacs: show: set default show-all-multipart/alternatives to nil Mark Walters
2012-12-15 5:52 ` [PATCH v2 0/5] Use invisibility to toggle display of all parts including multipart Austin Clements
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1355389924-3718-2-git-send-email-markwalters1009@gmail.com \
--to=markwalters1009@gmail.com \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).