unofficial mirror of notmuch@notmuchmail.org
 help / color / mirror / code / Atom feed
From: david@tethera.net
To: notmuch@notmuchmail.org
Cc: David Bremner <bremner@debian.org>
Subject: [Patch v5 09/11] test/dump-restore: add test for warning/error messages
Date: Sat,  8 Dec 2012 18:56:59 -0400	[thread overview]
Message-ID: <1355007421-3069-10-git-send-email-david@tethera.net> (raw)
In-Reply-To: <1355007421-3069-1-git-send-email-david@tethera.net>

From: David Bremner <bremner@debian.org>

We want to test both that error/warning messages are generated when
they should be, and not generated when they should not be. This varies
between restore and batch tagging.
---
 test/dump-restore |   35 +++++++++++++++++++++++++++++++++++
 1 file changed, 35 insertions(+)

diff --git a/test/dump-restore b/test/dump-restore
index 7d91cca..6a989b6 100755
--- a/test/dump-restore
+++ b/test/dump-restore
@@ -181,6 +181,41 @@ notmuch restore < EXPECTED.$test_count
 notmuch dump --format=sup > OUTPUT.$test_count
 test_expect_equal_file EXPECTED.$test_count OUTPUT.$test_count
 
+test_begin_subtest 'restore: checking error messages'
+notmuch restore <<EOF 2>OUTPUT
+# the next line has a space
+ 
+a
++0
++a +b
+# trailing whitespace
++a +b 
++c +d --
+# this is a harmless comment, do not yell about it.
+
+# the previous line was blank; also no yelling please
++%zz -- id:whatever
++e +f id:%yy
+# the next non-comment line should report an an empty tag error for
+# batch tagging, but not for restore
++ +e -- id:20091117232137.GA7669@griffis1.net
+# highlight the sketchy id parsing; this should be last
++g -- id:foo and bar
+EOF
+
+cat <<EOF > EXPECTED
+Warning: unsupported query: a
+Warning: no query string [+0]
+Warning: no query string [+a +b]
+Warning: missing query string [+a +b ]
+Warning: no query string after -- [+c +d --]
+Warning: hex decoding of tag %zz failed [+%zz -- id:whatever]
+Warning: hex decoding of query id:%yy failed [+e +f id:%yy]
+Warning: cannot apply tags to missing message: foo and bar
+EOF
+
+test_expect_equal_file EXPECTED OUTPUT
+
 test_begin_subtest 'roundtripping random message-ids and tags'
 
     ${TEST_DIRECTORY}/random-corpus --config-path=${NOTMUCH_CONFIG} \
-- 
1.7.10.4

  parent reply	other threads:[~2012-12-08 22:57 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-12-08 22:56 v5 of Batch-tag dump/restore patches david
2012-12-08 22:56 ` [Patch v5 01/11] notmuch-dump: add --format=(batch-tag|sup) david
2012-12-08 22:56 ` [Patch v5 02/11] test: add sanity check for dump --format=batch-tag david
2012-12-08 22:56 ` [Patch v5 03/11] util: add string-util.[ch] david
2012-12-08 22:56 ` [Patch v5 04/11] tag-util.[ch]: New files for common tagging routines david
2012-12-08 22:56 ` [Patch v5 05/11] notmuch-restore: add support for input format 'batch-tag' david
2012-12-08 22:56 ` [Patch v5 06/11] notmuch-restore: normalize case of error messages david
2012-12-08 22:56 ` [Patch v5 07/11] test: update dump-restore roundtripping test for batch-tag format david
2012-12-08 22:56 ` [Patch v5 08/11] test: second set of dump/restore --format=batch-tag tests david
2012-12-08 22:56 ` david [this message]
2012-12-08 22:57 ` [Patch v5 10/11] notmuch-{dump, restore}.1: document new format options david
2012-12-08 22:57 ` [Patch v5 11/11] tag-util: optimization of tag application david
2012-12-09 12:55 ` v5 of Batch-tag dump/restore patches David Bremner
2012-12-09 13:46   ` Jani Nikula
2012-12-09 17:17   ` Mark Walters
2012-12-09 23:05 ` David Bremner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://notmuchmail.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1355007421-3069-10-git-send-email-david@tethera.net \
    --to=david@tethera.net \
    --cc=bremner@debian.org \
    --cc=notmuch@notmuchmail.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://yhetil.org/notmuch.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).