From: Mark Walters <markwalters1009@gmail.com>
To: notmuch@notmuchmail.org
Subject: [PATCH v2] emacs: stash bugfix
Date: Wed, 5 Dec 2012 12:20:54 +0000 [thread overview]
Message-ID: <1354710054-23093-1-git-send-email-markwalters1009@gmail.com> (raw)
In-Reply-To: <20121203152015.GD1020@mit.edu>
Currently an attempt to stash a non-existent field (eg cc when not
present) throws an error. Catch this case and give the user a warning
message.
---
This fixes the comment and stashes an empty string in the
case there is nothing to stash (both suggested by Austin).
emacs/notmuch-lib.el | 10 ++++++++--
1 files changed, 8 insertions(+), 2 deletions(-)
diff --git a/emacs/notmuch-lib.el b/emacs/notmuch-lib.el
index 1d0ec17..5c44867 100644
--- a/emacs/notmuch-lib.el
+++ b/emacs/notmuch-lib.el
@@ -183,8 +183,14 @@ user-friendly queries."
(defun notmuch-common-do-stash (text)
"Common function to stash text in kill ring, and display in minibuffer."
- (kill-new text)
- (message "Stashed: %s" text))
+ (if text
+ (progn
+ (kill-new text)
+ (message "Stashed: %s" text))
+ ;; There is nothing to stash so stash an empty string so the user
+ ;; doesn't accidentally paste something else somewhere.
+ (kill-new "")
+ (message "Nothing to stash!")))
;;
--
1.7.9.1
next prev parent reply other threads:[~2012-12-05 12:21 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-02 10:11 [PATCH] emacs: stash bugfix Mark Walters
2012-12-02 11:04 ` Tomi Ollila
2012-12-03 1:34 ` Austin Clements
2012-12-03 9:27 ` Mark Walters
2012-12-03 15:20 ` Austin Clements
2012-12-05 12:20 ` Mark Walters [this message]
2012-12-05 16:01 ` [PATCH v2] " Austin Clements
2012-12-06 21:25 ` David Bremner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1354710054-23093-1-git-send-email-markwalters1009@gmail.com \
--to=markwalters1009@gmail.com \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).