unofficial mirror of notmuch@notmuchmail.org
 help / color / mirror / code / Atom feed
From: Mark Walters <markwalters1009@gmail.com>
To: notmuch@notmuchmail.org
Subject: [PATCH] emacs: show: make RET always toggle parts where plausible
Date: Wed,  5 Dec 2012 09:41:20 +0000	[thread overview]
Message-ID: <1354700480-5170-1-git-send-email-markwalters1009@gmail.com> (raw)
In-Reply-To: <1354663662-20524-4-git-send-email-markwalters1009@gmail.com>

This makes RET toggle the visibility of any part which has a component
that can be displayed in the buffer. This included text parts (plain/
html/ x-tex etc) and images. Parts which cannot be displayed (eg pdf)
RET acts as before and saves/views etc.

Definite actions can always be accessed with s,v and o (eg v to view a
text/html part in a browser).

---

This is a slight tweak at Jani's suggestion on irc. Applies on top of
the previous series.



 emacs/notmuch-show.el |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el
index a4daff8..e319e5c 100644
--- a/emacs/notmuch-show.el
+++ b/emacs/notmuch-show.el
@@ -2028,7 +2028,7 @@ the user (see `notmuch-show-stash-mlarchive-link-alist')."
 (defun notmuch-show-part-button-default (&optional button)
   (interactive)
   (let ((button (or button (button-at (point)))))
-    (if (invisible-p (button-get button 'invisibility-spec))
+    (if (button-get button 'invisibility-spec)
 	(notmuch-show-toggle-invisible-part-action button)
       (notmuch-show-part-button-internal button notmuch-show-part-button-default-action))))
 
-- 
1.7.9.1

  reply	other threads:[~2012-12-05  9:41 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-12-04 23:27 [PATCH 0/3] Use invisibility to toggle display of all parts including multipart Mark Walters
2012-12-04 23:27 ` [PATCH 1/3] emacs: show: modify insert-part-header to save the button text Mark Walters
2012-12-11  0:22   ` Austin Clements
2012-12-04 23:27 ` [PATCH 2/3] emacs: show: add overlays for each part Mark Walters
2012-12-11  3:59   ` Austin Clements
2012-12-13  8:54     ` Mark Walters
2012-12-15  5:16       ` Austin Clements
2012-12-04 23:27 ` [PATCH 3/3] emacs: show: add invisibility button action Mark Walters
2012-12-05  9:41   ` Mark Walters [this message]
2012-12-11  4:07     ` [PATCH] emacs: show: make RET always toggle parts where plausible Austin Clements
2012-12-11  4:06   ` [PATCH 3/3] emacs: show: add invisibility button action Austin Clements
2012-12-13  8:57     ` Mark Walters
2012-12-05 17:24 ` [PATCH 0/3] Use invisibility to toggle display of all parts including multipart Jani Nikula

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://notmuchmail.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1354700480-5170-1-git-send-email-markwalters1009@gmail.com \
    --to=markwalters1009@gmail.com \
    --cc=notmuch@notmuchmail.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://yhetil.org/notmuch.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).