unofficial mirror of notmuch@notmuchmail.org
 help / color / mirror / code / Atom feed
From: Mark Walters <markwalters1009@gmail.com>
To: notmuch@notmuchmail.org
Subject: [PATCH] emacs: stash bugfix
Date: Sun,  2 Dec 2012 10:11:08 +0000	[thread overview]
Message-ID: <1354443068-5030-1-git-send-email-markwalters1009@gmail.com> (raw)

Currently an attempt to stash a non-existent field (eg cc when not
present) throws an error. Catch this case and give the user a warning
message.

---
While messing around with notmuch-pick key bindings I found the
following bug. The easiest way I have found to trigger it is cc
(stash-cc) in show mode on a message with no cc header.

Best wishes

Mark

 emacs/notmuch-lib.el |    7 +++++--
 1 files changed, 5 insertions(+), 2 deletions(-)

diff --git a/emacs/notmuch-lib.el b/emacs/notmuch-lib.el
index 1d0ec17..c7d8e02 100644
--- a/emacs/notmuch-lib.el
+++ b/emacs/notmuch-lib.el
@@ -183,8 +183,11 @@ user-friendly queries."
 
 (defun notmuch-common-do-stash (text)
   "Common function to stash text in kill ring, and display in minibuffer."
-  (kill-new text)
-  (message "Stashed: %s" text))
+  (if text
+      (progn
+	(kill-new text)
+	(message "Stashed: %s" text))
+    (message "Warning: Nothing to stash!")))
 
 ;;
 
-- 
1.7.9.1

             reply	other threads:[~2012-12-02 10:11 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-12-02 10:11 Mark Walters [this message]
2012-12-02 11:04 ` [PATCH] emacs: stash bugfix Tomi Ollila
2012-12-03  1:34 ` Austin Clements
2012-12-03  9:27   ` Mark Walters
2012-12-03 15:20     ` Austin Clements
2012-12-05 12:20       ` [PATCH v2] " Mark Walters
2012-12-05 16:01         ` Austin Clements
2012-12-06 21:25         ` David Bremner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://notmuchmail.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1354443068-5030-1-git-send-email-markwalters1009@gmail.com \
    --to=markwalters1009@gmail.com \
    --cc=notmuch@notmuchmail.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://yhetil.org/notmuch.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).