From: Austin Clements <amdragon@MIT.EDU>
To: notmuch@notmuchmail.org
Subject: [PATCH 2/3] show: More aggressively document the presence of devel/schemata
Date: Wed, 7 Nov 2012 10:27:01 -0500 [thread overview]
Message-ID: <1352302022-21486-3-git-send-email-amdragon@mit.edu> (raw)
In-Reply-To: <1352302022-21486-1-git-send-email-amdragon@mit.edu>
Previously, the only mention of devel/schemata was a comment at the
top of format_part_json, but the JSON output code is spread across
several functions that are distributed across notmuch-show.c. Add
references from the other three key JSON output functions.
---
notmuch-show.c | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/notmuch-show.c b/notmuch-show.c
index f758f56..2fa2292 100644
--- a/notmuch-show.c
+++ b/notmuch-show.c
@@ -110,6 +110,9 @@ _get_one_line_summary (const void *ctx, notmuch_message_t *message)
static void
format_message_json (sprinter_t *sp, notmuch_message_t *message)
{
+ /* Any changes to the JSON format should be reflected in the file
+ * devel/schemata. */
+
void *local = talloc_new (NULL);
notmuch_tags_t *tags;
time_t date;
@@ -208,6 +211,9 @@ void
format_headers_json (sprinter_t *sp, GMimeMessage *message,
notmuch_bool_t reply)
{
+ /* Any changes to the JSON format should be reflected in the file
+ * devel/schemata. */
+
InternetAddressList *recipients;
const char *recipients_string;
const char *reply_to_string;
@@ -359,6 +365,9 @@ signer_status_to_string (GMimeSignerStatus x)
static void
format_part_sigstatus_json (sprinter_t *sp, mime_node_t *node)
{
+ /* Any changes to the JSON format should be reflected in the file
+ * devel/schemata. */
+
GMimeSignatureList *siglist = node->sig_list;
sp->begin_list (sp);
--
1.7.10
next prev parent reply other threads:[~2012-11-07 15:27 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-07 15:26 [PATCH 0/3] Sync devel/schemata with code Austin Clements
2012-11-07 15:27 ` [PATCH 1/3] devel: Add Reply-to to the schemata Austin Clements
2012-11-08 13:54 ` David Bremner
2012-11-07 15:27 ` Austin Clements [this message]
2012-11-07 15:27 ` [PATCH 3/3] devel: Document schemata in STYLE Austin Clements
2012-11-07 15:40 ` [PATCH 0/3] Sync devel/schemata with code Tomi Ollila
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1352302022-21486-3-git-send-email-amdragon@mit.edu \
--to=amdragon@mit.edu \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).