From: Tomi Ollila <tomi.ollila@iki.fi>
To: notmuch@notmuchmail.org
Cc: tomi.ollila@iki.fi
Subject: [PATCH 1/1] emacs/notmuch-show.el: handle bodypart insert error
Date: Sun, 21 Oct 2012 16:35:09 +0300 [thread overview]
Message-ID: <1350826509-12119-1-git-send-email-tomi.ollila@iki.fi> (raw)
When inserting of email bodypart failes, insert a failure message
to the buffer (and continue) instead of halting the insertion of
the rest of that email thread in question.
---
This is (now real !!!) alternative to
id:"1350824336-11060-1-git-send-email-tomi.ollila@iki.fi"
This adds error message string to the output, error message in
id:"87d31artti.fsf@inf-8657.int-evry.fr" is shown as
!!! Bodypart insert error: Wrong type argument: stringp, nil !!!
See id:"1350824336-11060-1-git-send-email-tomi.ollila@iki.fi"
for more discussion.
emacs/notmuch-show.el | 7 ++++++-
1 files changed, 6 insertions(+), 1 deletions(-)
diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el
index f273eb4..d061367 100644
--- a/emacs/notmuch-show.el
+++ b/emacs/notmuch-show.el
@@ -815,7 +815,12 @@ message at DEPTH in the current thread."
;; Run the content handlers until one of them returns a non-nil
;; value.
(while (and handlers
- (not (funcall (car handlers) msg part content-type nth depth declared-type)))
+ (not (condition-case err
+ (funcall (car handlers) msg part content-type nth depth declared-type)
+ (error (progn
+ (insert "!!! Bodypart insert error: ")
+ (insert (error-message-string err))
+ (insert " !!!\n") nil)))))
(setq handlers (cdr handlers))))
t)
--
1.7.1
next reply other threads:[~2012-10-21 13:35 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-21 13:35 Tomi Ollila [this message]
2012-10-21 14:10 ` [PATCH 1/1] emacs/notmuch-show.el: handle bodypart insert error Ethan
2012-10-31 20:35 ` David Bremner
2012-11-07 12:10 ` David Bremner
-- strict thread matches above, loose matches on Subject: below --
2012-10-21 13:20 Tomi Ollila
2012-10-21 13:26 ` Tomi Ollila
2012-10-21 12:58 Tomi Ollila
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1350826509-12119-1-git-send-email-tomi.ollila@iki.fi \
--to=tomi.ollila@iki.fi \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).